From: Damien Lespiau <damien.lespiau@intel.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/7] drm: Renaming DP training vswing pre emph defines
Date: Thu, 28 Aug 2014 08:01:51 +0100 [thread overview]
Message-ID: <20140828070151.GC5495@strange.ger.corp.intel.com> (raw)
In-Reply-To: <20140827131107.GI23186@ulmo>
On Wed, Aug 27, 2014 at 03:11:08PM +0200, Thierry Reding wrote:
> > So we're left with
> >
> > #define DP_TRAIN_VOLTAGE_SWING_LEVEL_0 (0 << 0)
> >
> > Vs
> >
> > #define DP_TRAIN_VOLTAGE_SWING_LEVEL(x) ((x) << 0)
> >
> > The second variant doesn't really bring much more clarity? Can we just
> > go with the first?
>
> I think the parameterized version is more convenient, especially if you
> want to use that during training sequences and iterate over the levels.
That's a fair point, but today's code manages to do without that nicety.
I think these kind of refinements could go in series with code actually
using them on top.
> But I don't feel too strongly about it, so either way is fine with me.
Thanks, taking some of your time to provide feedback is always
appreciated!
--
Damien
next prev parent reply other threads:[~2014-08-28 7:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 10:53 [PATCH v2 0/7] Rename DP training vswing/pre-emph defines sonika.jindal
2014-08-08 10:53 ` [PATCH 1/7] drm: Renaming DP training vswing pre emph defines sonika.jindal
2014-08-11 16:59 ` [Intel-gfx] " Damien Lespiau
2014-08-26 11:28 ` Thierry Reding
2014-08-27 4:31 ` Jindal, Sonika
2014-08-28 0:34 ` Jingoo Han
2014-08-27 7:47 ` Damien Lespiau
2014-08-27 7:51 ` Damien Lespiau
2014-08-27 13:09 ` Thierry Reding
2014-08-27 13:11 ` Thierry Reding
2014-08-28 7:01 ` Damien Lespiau [this message]
2014-08-08 10:53 ` [PATCH 2/7] drm/i915: " sonika.jindal
2014-08-11 17:04 ` Damien Lespiau
2014-08-08 10:53 ` [PATCH 3/7] drm/exynos: " sonika.jindal
2014-08-28 0:55 ` Jingoo Han
2014-08-28 4:32 ` Jindal, Sonika
2014-08-28 6:06 ` Jingoo Han
2014-08-28 6:11 ` Jindal, Sonika
2014-08-08 10:53 ` [PATCH 4/7] drm/gma500: " sonika.jindal
2014-08-08 10:53 ` [PATCH 5/7] drm/radeon: " sonika.jindal
2014-08-08 10:53 ` [PATCH 6/7] drm/tegra: " sonika.jindal
2014-08-08 10:53 ` [PATCH 7/7] drm: Remove old defines for vswing and pre-emph values sonika.jindal
2014-08-19 8:12 ` [PATCH v2 0/7] Rename DP training vswing/pre-emph defines Jindal, Sonika
2014-08-25 12:55 ` [Intel-gfx] " Daniel Vetter
2014-08-27 6:08 ` Jindal, Sonika
2014-08-27 13:44 ` [Intel-gfx] " Deucher, Alexander
2014-09-02 20:46 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140828070151.GC5495@strange.ger.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox