From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Don't use
 WaGsvRC0ResidenncyMethod on chv
Date: Fri, 29 Aug 2014 16:01:50 +0300
Message-ID: <20140829130150.GX4193@intel.com>
References: <1409310847-24105-1-git-send-email-ville.syrjala@linux.intel.com>
 <20140829112127.GG3557@nuc-i3427.alporthouse.com>
 <20140829120949.GW4193@intel.com>
 <20140829125104.GH3557@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTP id B355189FF7
 for <intel-gfx@lists.freedesktop.org>; Fri, 29 Aug 2014 06:01:56 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140829125104.GH3557@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Aug 29, 2014 at 01:51:04PM +0100, Chris Wilson wrote:
> On Fri, Aug 29, 2014 at 03:09:49PM +0300, Ville Syrj=E4l=E4 wrote:
> > On Fri, Aug 29, 2014 at 12:21:27PM +0100, Chris Wilson wrote:
> > > On Fri, Aug 29, 2014 at 02:14:07PM +0300, ville.syrjala@linux.intel.c=
om wrote:
> > > > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > > > =

> > > > WaGsvRC0ResidenncyMethod is for vlv, it doesn't deal with chv
> > > > appropriately (eg. doesn't limit rps values to even numbers).
> > > > =

> > > > Fix a typo in the w/a name while at it.
> > > =

> > > You could review my changes for the vlv manual calculations that would
> > > fix it for chv as well...
> > =

> > IIRC I glanced at them but there was too much noise in some of the
> > patches for my poor brain so I gave up.
> =

> Could you clarify whether you mean WaGsvRC0ResidenncyMethod is only
> intended for vlv (fixed for chv), or whether just the implementation is
> currently only for chv.

At least the w/a isn't listed for chv currently.

> =

> If the former, and the code is no longer required,
> Reviewed-by: Chris Wilson <chris@chris-wilson.o.uk>
> -Chris
> =

> -- =

> Chris Wilson, Intel Open Source Technology Centre

-- =

Ville Syrj=E4l=E4
Intel OTC