From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 13/16] drm/i915: Fix DVO 2x clock enable on 830M Date: Mon, 1 Sep 2014 10:46:44 +0200 Message-ID: <20140901084644.GT15520@phenom.ffwll.local> References: <1408054928-24141-1-git-send-email-ville.syrjala@linux.intel.com> <1408054928-24141-14-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-we0-f180.google.com (mail-we0-f180.google.com [74.125.82.180]) by gabe.freedesktop.org (Postfix) with ESMTP id 15F876E2FF for ; Mon, 1 Sep 2014 01:46:21 -0700 (PDT) Received: by mail-we0-f180.google.com with SMTP id w61so5024721wes.25 for ; Mon, 01 Sep 2014 01:46:21 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1408054928-24141-14-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com Cc: Thomas Richter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBBdWcgMTUsIDIwMTQgYXQgMDE6MjI6MDVBTSArMDMwMCwgdmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20gd3JvdGU6Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBUaGUgc3BlYyBzYXlzOgo+ICJGb3IgdGhlIGNvcnJl Y3Qgb3BlcmF0aW9uIG9mIHRoZSBtdXhlZCBEVk8gcGlucyAoR0RFVlNFTEIvIEkyQ2RhdGEsCj4g R0lSREJZL0kyQ0NsaykgYW5kIChHRlJBTUVCL0RWSV9EYXRhLCBHVFJEWUIvRFZJX0Nsayk6IEJp dCAzMQo+IChEUExMIFZDTyBFbmFibGUpIGFuZCBCaXQgMzAgKDJYIENsb2NrIEVuYWJsZSkgbXVz dCBiZSBzZXQgdG8g4oCcMeKAnSBpbgo+IGJvdGggdGhlIERQTEwgQSBDb250cm9sIFJlZ2lzdGVy ICgwNjAxNGgtMDYwMTdoKSBhbmQgRFBMTCBCIENvbnRyb2wKPiBSZWdpc3RlciAoMDYwMThoLTA2 MDFCaCkuIgo+IAo+IFRoZSBwaXBlIEEgYW5kIEIgZm9yY2UgcXVpcmtzIHRha2UgY2FyZSBvZiBE UExMX1ZDT19FTkFCTEUsIHNvIHdlCj4ganVzdCBuZWVkIGEgYml0IG9mIHNwZWNpYWwgY2FyZSB0 byBoYW5kbGUgRFBMTF9EVk9fMlhfTU9ERS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJq w6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2Rydi5oICAgICAgfCAgMyArKysKPiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jIHwgNDcgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr LS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgNDYgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkK PiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBpbmRleCA1NDFmYjZmLi41NDg5NWE2IDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gQEAgLTE1NjEsNiArMTU2MSw5IEBAIHN0cnVjdCBk cm1faTkxNV9wcml2YXRlIHsKPiAgCj4gIAl1MTYgb3JpZ19jbG9jazsKPiAgCj4gKwkvKiB1c2Vk IHRvIGNvbnRyb2wgRFZPIDJ4IGNsb2NrIGVuYWJsZSBvbiA4MzBNICovCj4gKwl1aW50OF90IGR2 b19waXBlczsKPiArCj4gIAlib29sIG1jaGJhcl9uZWVkX2Rpc2FibGU7Cj4gIAo+ICAJc3RydWN0 IGludGVsX2wzX3Bhcml0eSBsM19wYXJpdHk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs YXkuYwo+IGluZGV4IDNlZWI1Y2UuLjY0NjJiY2YgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGlzcGxheS5jCj4gQEAgLTE1NDgsNiArMTU0OCw3IEBAIHN0YXRpYyB2b2lkIGk5eHhfZW5h YmxlX3BsbChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPiAgewo+ICAJc3RydWN0IGRybV9kZXZp Y2UgKmRldiA9IGNydGMtPmJhc2UuZGV2Owo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiArCWVudW0gcGlwZSBwaXBlID0gY3J0Yy0+cGlw ZTsKPiAgCWludCByZWcgPSBEUExMKGNydGMtPnBpcGUpOwo+ICAJdTMyIGRwbGwgPSBjcnRjLT5j b25maWcuZHBsbF9od19zdGF0ZS5kcGxsOwo+ICAKPiBAQCAtMTU2MCw3ICsxNTYxLDE2IEBAIHN0 YXRpYyB2b2lkIGk5eHhfZW5hYmxlX3BsbChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPiAgCWlm IChJU19NT0JJTEUoZGV2KSAmJiAhSVNfSTgzMChkZXYpKQo+ICAJCWFzc2VydF9wYW5lbF91bmxv Y2tlZChkZXZfcHJpdiwgY3J0Yy0+cGlwZSk7Cj4gIAo+IC0JSTkxNV9XUklURShyZWcsIGRwbGwp Owo+ICsJLyogZW5hYmxlIERWTyAyeCBjbG9jayBvbiBib3RoIFBMTHMgaWYgbmVjZXNzYXJ5ICov Cj4gKwlpZiAoSVNfSTgzMChkZXYpKSB7Cj4gKwkJaWYgKGludGVsX3BpcGVfaGFzX3R5cGUoJmNy dGMtPmJhc2UsIElOVEVMX09VVFBVVF9EVk8pKQo+ICsJCQlkZXZfcHJpdi0+ZHZvX3BpcGVzIHw9 IDEgPDwgcGlwZTsKPiArCj4gKwkJaWYgKGRldl9wcml2LT5kdm9fcGlwZXMpIHsKPiArCQkJZHBs bCB8PSBEUExMX0RWT18yWF9NT0RFOwo+ICsJCQlJOTE1X1dSSVRFKERQTEwoIXBpcGUpLCBJOTE1 X1JFQUQoRFBMTCghcGlwZSkpIHwgRFBMTF9EVk9fMlhfTU9ERSk7Cj4gKwkJfQo+ICsJfQo+ICAK PiAgCS8qIFdhaXQgZm9yIHRoZSBjbG9ja3MgdG8gc3RhYmlsaXplLiAqLwo+ICAJUE9TVElOR19S RUFEKHJlZyk7Cj4gQEAgLTE1OTksOCArMTYwOSwyMyBAQCBzdGF0aWMgdm9pZCBpOXh4X2VuYWJs ZV9wbGwoc3RydWN0IGludGVsX2NydGMgKmNydGMpCj4gICAqCj4gICAqIE5vdGUhICBUaGlzIGlz IGZvciBwcmUtSUxLIG9ubHkuCj4gICAqLwo+IC1zdGF0aWMgdm9pZCBpOXh4X2Rpc2FibGVfcGxs KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgZW51bSBwaXBlIHBpcGUpCj4gK3N0 YXRpYyB2b2lkIGk5eHhfZGlzYWJsZV9wbGwoc3RydWN0IGludGVsX2NydGMgKmNydGMpCj4gIHsK PiArCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBjcnRjLT5iYXNlLmRldjsKPiArCXN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gKwllbnVtIHBp cGUgcGlwZSA9IGNydGMtPnBpcGU7Cj4gKwo+ICsJLyogZGlzYWJsZSBEVk8gMnggY2xvY2sgb24g Ym90aCBQTExzIGlmIG5lY2Vzc2FyeSAqLwo+ICsJaWYgKElTX0k4MzAoZGV2KSkgewo+ICsJCWlm IChpbnRlbF9waXBlX2hhc190eXBlKCZjcnRjLT5iYXNlLCBJTlRFTF9PVVRQVVRfRFZPKSkKPiAr CQkJZGV2X3ByaXYtPmR2b19waXBlcyAmPSB+KDEgPDwgcGlwZSk7Cj4gKwo+ICsJCWlmICghZGV2 X3ByaXYtPmR2b19waXBlcykgewo+ICsJCQlJOTE1X1dSSVRFKERQTEwocGlwZSksIEk5MTVfUkVB RChEUExMKHBpcGUpKSAmIH5EUExMX0RWT18yWF9NT0RFKTsKPiArCQkJSTkxNV9XUklURShEUExM KCFwaXBlKSwgSTkxNV9SRUFEKERQTEwoIXBpcGUpKSAmIH5EUExMX0RWT18yWF9NT0RFKTsKCkJp a2VzaGVkOiBJJ2QganVzdCB1c2UgZXhwbGljaXQgUElQRV9BIGFuZCBQSVBFX0IgaGVyZSwgZXhj ZXB0IHdoZW4gd2UKcmVhbGx5IGhhdmUgdG8gdHVybiBvZiBvdXIgcGlwZSBmaXJzdCBiZWZvcmUg dGhlIG90aGVyLgoKPiArCQl9Cj4gKwl9Cj4gKwo+ICAJLyogRG9uJ3QgZGlzYWJsZSBwaXBlIEEg b3IgcGlwZSBBIFBMTHMgaWYgbmVlZGVkICovCj4gIAlpZiAocGlwZSA9PSBQSVBFX0EgJiYgKGRl dl9wcml2LT5xdWlya3MgJiBRVUlSS19QSVBFQV9GT1JDRSkpCj4gIAkJcmV0dXJuOwo+IEBAIC00 Nzg4LDcgKzQ4MTMsNyBAQCBzdGF0aWMgdm9pZCBpOXh4X2NydGNfZGlzYWJsZShzdHJ1Y3QgZHJt X2NydGMgKmNydGMpCj4gIAkJZWxzZSBpZiAoSVNfVkFMTEVZVklFVyhkZXYpKQo+ICAJCQl2bHZf ZGlzYWJsZV9wbGwoZGV2X3ByaXYsIHBpcGUpOwo+ICAJCWVsc2UKPiAtCQkJaTl4eF9kaXNhYmxl X3BsbChkZXZfcHJpdiwgcGlwZSk7Cj4gKwkJCWk5eHhfZGlzYWJsZV9wbGwoaW50ZWxfY3J0Yyk7 Cj4gIAl9Cj4gIAo+ICAJaWYgKCFJU19HRU4yKGRldikpCj4gQEAgLTU3OTIsNyArNTgxNyw3IEBA IHN0YXRpYyB2b2lkIGk4eHhfdXBkYXRlX3BsbChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiAg CQkJZHBsbCB8PSBQTExfUDJfRElWSURFX0JZXzQ7Cj4gIAl9Cj4gIAo+IC0JaWYgKGludGVsX3Bp cGVfaGFzX3R5cGUoJmNydGMtPmJhc2UsIElOVEVMX09VVFBVVF9EVk8pKQo+ICsJaWYgKCFJU19J ODMwKGRldikgJiYgaW50ZWxfcGlwZV9oYXNfdHlwZSgmY3J0Yy0+YmFzZSwgSU5URUxfT1VUUFVU X0RWTykpCj4gIAkJZHBsbCB8PSBEUExMX0RWT18yWF9NT0RFOwo+ICAKPiAgCWlmIChpbnRlbF9w aXBlX2hhc190eXBlKCZjcnRjLT5iYXNlLCBJTlRFTF9PVVRQVVRfTFZEUykgJiYKPiBAQCAtNjI5 OCw2ICs2MzIzLDkgQEAgc3RhdGljIGJvb2wgaTl4eF9nZXRfcGlwZV9jb25maWcoc3RydWN0IGlu dGVsX2NydGMgKmNydGMsCj4gIAl9Cj4gIAlwaXBlX2NvbmZpZy0+ZHBsbF9od19zdGF0ZS5kcGxs ID0gSTkxNV9SRUFEKERQTEwoY3J0Yy0+cGlwZSkpOwo+ICAJaWYgKCFJU19WQUxMRVlWSUVXKGRl dikpIHsKPiArCQlpZiAoSVNfSTgzMChkZXYpKQo+ICsJCQlwaXBlX2NvbmZpZy0+ZHBsbF9od19z dGF0ZS5kcGxsICY9IH5EUExMX0RWT18yWF9NT0RFOwo+ICsKPiAgCQlwaXBlX2NvbmZpZy0+ZHBs bF9od19zdGF0ZS5mcDAgPSBJOTE1X1JFQUQoRlAwKGNydGMtPnBpcGUpKTsKPiAgCQlwaXBlX2Nv bmZpZy0+ZHBsbF9od19zdGF0ZS5mcDEgPSBJOTE1X1JFQUQoRlAxKGNydGMtPnBpcGUpKTsKPiAg CX0gZWxzZSB7Cj4gQEAgLTEzMDIxLDYgKzEzMDQ5LDE3IEBAIHZvaWQgaW50ZWxfbW9kZXNldF9z ZXR1cF9od19zdGF0ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJCX0KPiAgCX0KPiAgCj4g KwkvKiB1cGRhdGUgZHZvX3BpcGVzICovCj4gKwlpZiAoSVNfSTgzMChkZXYpKSB7Cj4gKwkJZGV2 X3ByaXYtPmR2b19waXBlcyA9IDA7Cj4gKwo+ICsJCWZvcl9lYWNoX2ludGVsX2NydGMoZGV2LCBj cnRjKSB7Cj4gKwkJCWlmIChjcnRjLT5hY3RpdmUgJiYKPiArCQkJICAgIGludGVsX3BpcGVfaGFz X3R5cGUoJmNydGMtPmJhc2UsIElOVEVMX09VVFBVVF9EVk8pKQo+ICsJCQkJZGV2X3ByaXYtPmR2 b19waXBlcyB8PSAxIDw8IGNydGMtPnBpcGU7Cj4gKwkJfQo+ICsJfQoKVGhpcyBwdXRzIGd1bmsg aW50byB0aGUgbW9kZXNldCBodyBzdGF0ZSBzdHVmZi4gSW1vIGp1c3QgbG9vcCBvdmVyIGFsbApw aXBlcyBhbmQgcmVjb21wdXRlIHRoZSBpODMwX25lZWRzX2R2b18yeCBldmVyeXdoZXJlIHlvdSBu ZWVkIGl0LCBpbnN0ZWFkCm9mIGFkZGluZyBhIG5ldyBkZXZfcHJpdi0+ZHZvX3BpcGVzIHN0YXRl IHdoaWNoIG1pZ2h0IGdldCBvdXQgb2Ygc3luYwpldmVudHVhbGx5LgoKSSdsbCBwdW50IG9uIHRo aXMgZm9yIG5vdy4KLURhbmllbAoKPiArCj4gIAkvKiBIVyBzdGF0ZSBpcyByZWFkIG91dCwgbm93 IHdlIG5lZWQgdG8gc2FuaXRpemUgdGhpcyBtZXNzLiAqLwo+ICAJZm9yX2VhY2hfaW50ZWxfZW5j b2RlcihkZXYsIGVuY29kZXIpIHsKPiAgCQlpbnRlbF9zYW5pdGl6ZV9lbmNvZGVyKGVuY29kZXIp Owo+IC0tIAo+IDEuOC41LjUKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIElu dGVsIENvcnBvcmF0aW9uCis0MSAoMCkgNzkgMzY1IDU3IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3bGwu Y2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK