From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v2] drm/i915: Fix lock dropping in
	intel_tv_detect()
Date: Tue, 2 Sep 2014 11:16:12 +0300
Message-ID: <20140902081612.GH4193@intel.com>
References: <20140901085022.GB11648@nuc-i3427.alporthouse.com>
 <1409566060-21337-1-git-send-email-ville.syrjala@linux.intel.com>
 <20140901102009.GD11648@nuc-i3427.alporthouse.com>
 <20140901103637.GB4193@intel.com>
 <20140901104356.GE11648@nuc-i3427.alporthouse.com>
 <87egvuii5q.fsf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTP id CC0C06E41C
 for <intel-gfx@lists.freedesktop.org>; Tue,  2 Sep 2014 01:16:17 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <87egvuii5q.fsf@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Tibor Billes <tbilles@gmx.com>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Sep 02, 2014 at 10:41:05AM +0300, Jani Nikula wrote:
> On Mon, 01 Sep 2014, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > On Mon, Sep 01, 2014 at 01:36:37PM +0300, Ville Syrj=E4l=E4 wrote:
> >> On Mon, Sep 01, 2014 at 11:20:09AM +0100, Chris Wilson wrote:
> >> > On Mon, Sep 01, 2014 at 01:07:40PM +0300, ville.syrjala@linux.intel.=
com wrote:
> >> > > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> >> > > =

> >> > > When intel_tv_detect() fails to do load detection it would forget =
to
> >> > > drop the locks and clean up the acquire context. Fix it up.
> >> > > =

> >> > > This is a regression from:
> >> > >  commit 208bf9fdcd3575aa4a5d48b3e0295f7cdaf6fc44
> >> > >  Author: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> >> > >  Date:   Mon Aug 11 13:15:35 2014 +0300
> >> > > =

> >> > >     drm/i915: Fix locking for intel_enable_pipe_a()
> >> > > =

> >> > > v2: Make the code more readable (Chris)
> >> > > =

> >> > > Cc: Tibor Billes <tbilles@gmx.com>
> >> > > Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> >> > =

> >> > Hmm, if we use WARN_ON() you should init type.
> >> =

> >> type is always set in the branch that sets status=3Dconnected.
> >
> > Back to thinking about readability and making sure that the WARN_ON
> > never happens with just a glance. Otherwise, the WARN_ON would be better
> > as WARN_ON(unsigned)type >=3D last_tv_type); Or something. Anway, take
> > your pick and slap my r-b on it. :)
> =

> Ville?

I don't know anymore. Just kill the WARN_ON() if it makes things
confusing?

-- =

Ville Syrj=E4l=E4
Intel OTC