From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH -v2 1/4] drm/i915: init sprites with
 univeral plane init function
Date: Wed, 3 Sep 2014 11:18:27 +0300
Message-ID: <20140903081827.GP4193@intel.com>
References: <1409685827-29067-1-git-send-email-gustavo@padovan.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <1409685827-29067-1-git-send-email-gustavo@padovan.org>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Gustavo Padovan <gustavo@padovan.org>
Cc: intel-gfx@lists.freedesktop.org, Derek Foreman <derek.foreman@collabora.co.uk>, dri-devel@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Sep 02, 2014 at 04:23:44PM -0300, Gustavo Padovan wrote:
> From: Derek Foreman <derek.foreman@collabora.co.uk>
> =

> Really just for completeness - old init function ends up making the plane
> exactly the same way due to the way the enums are set up.
> =

> Signed-off-by: Derek Foreman <derek.foreman@collabora.co.uk>

Reviewed-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_sprite.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> =

> diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/i=
ntel_sprite.c
> index 0bdb00b..4cbe286 100644
> --- a/drivers/gpu/drm/i915/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/intel_sprite.c
> @@ -1375,10 +1375,10 @@ intel_plane_init(struct drm_device *dev, enum pip=
e pipe, int plane)
>  	intel_plane->plane =3D plane;
>  	intel_plane->rotation =3D BIT(DRM_ROTATE_0);
>  	possible_crtcs =3D (1 << pipe);
> -	ret =3D drm_plane_init(dev, &intel_plane->base, possible_crtcs,
> -			     &intel_plane_funcs,
> -			     plane_formats, num_plane_formats,
> -			     false);
> +	ret =3D drm_universal_plane_init(dev, &intel_plane->base, possible_crtc=
s,
> +				       &intel_plane_funcs,
> +				       plane_formats, num_plane_formats,
> +				       DRM_PLANE_TYPE_OVERLAY);
>  	if (ret) {
>  		kfree(intel_plane);
>  		goto out;
> -- =

> 1.9.3
> =

> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- =

Ville Syrj=E4l=E4
Intel OTC