From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org,
Derek Foreman <derek.foreman@collabora.co.uk>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH -v2 1/4] drm/i915: init sprites with univeral plane init function
Date: Wed, 3 Sep 2014 10:36:16 +0200 [thread overview]
Message-ID: <20140903083616.GE15520@phenom.ffwll.local> (raw)
In-Reply-To: <20140903081827.GP4193@intel.com>
On Wed, Sep 03, 2014 at 11:18:27AM +0300, Ville Syrjälä wrote:
> On Tue, Sep 02, 2014 at 04:23:44PM -0300, Gustavo Padovan wrote:
> > From: Derek Foreman <derek.foreman@collabora.co.uk>
> >
> > Really just for completeness - old init function ends up making the plane
> > exactly the same way due to the way the enums are set up.
> >
> > Signed-off-by: Derek Foreman <derek.foreman@collabora.co.uk>
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Queued for -next, thanks for the patch.
-Daniel
>
> > ---
> > drivers/gpu/drm/i915/intel_sprite.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> > index 0bdb00b..4cbe286 100644
> > --- a/drivers/gpu/drm/i915/intel_sprite.c
> > +++ b/drivers/gpu/drm/i915/intel_sprite.c
> > @@ -1375,10 +1375,10 @@ intel_plane_init(struct drm_device *dev, enum pipe pipe, int plane)
> > intel_plane->plane = plane;
> > intel_plane->rotation = BIT(DRM_ROTATE_0);
> > possible_crtcs = (1 << pipe);
> > - ret = drm_plane_init(dev, &intel_plane->base, possible_crtcs,
> > - &intel_plane_funcs,
> > - plane_formats, num_plane_formats,
> > - false);
> > + ret = drm_universal_plane_init(dev, &intel_plane->base, possible_crtcs,
> > + &intel_plane_funcs,
> > + plane_formats, num_plane_formats,
> > + DRM_PLANE_TYPE_OVERLAY);
> > if (ret) {
> > kfree(intel_plane);
> > goto out;
> > --
> > 1.9.3
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Ville Syrjälä
> Intel OTC
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-09-03 8:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 19:23 [PATCH -v2 1/4] drm/i915: init sprites with univeral plane init function Gustavo Padovan
2014-09-02 19:23 ` [PATCH -v2 2/4] drm/i915: trivial: remove unneed set to NULL Gustavo Padovan
2014-09-02 19:23 ` [PATCH -v2 3/4] drm/i915: create struct intel_plane_state Gustavo Padovan
2014-09-03 8:22 ` Ville Syrjälä
2014-09-02 19:23 ` [PATCH -v2 4/4] drm/i915: split intel_update_plane into check() and commit() Gustavo Padovan
2014-09-03 8:41 ` Ville Syrjälä
2014-09-03 8:18 ` [PATCH -v2 1/4] drm/i915: init sprites with univeral plane init function Ville Syrjälä
2014-09-03 8:36 ` Daniel Vetter [this message]
2014-09-03 8:38 ` Daniel Vetter
2014-09-03 10:36 ` Daniel Vetter
2014-09-03 13:38 ` [PATCH] " Gustavo Padovan
2014-09-03 13:44 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140903083616.GE15520@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=derek.foreman@collabora.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox