From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: bdw does not have pch backlight override bit Date: Thu, 4 Sep 2014 15:09:26 +0300 Message-ID: <20140904120926.GF4193@intel.com> References: <1409831769-2926-1-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 7C5256E514 for ; Thu, 4 Sep 2014 05:09:51 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1409831769-2926-1-git-send-email-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Sep 04, 2014 at 02:56:09PM +0300, Jani Nikula wrote: > BDW is always in the PCH override mode, and the bit MBZ. BSpec doesn't seem to agree. In fact it says the override must be enabled on bdw. > = > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_panel.c | 3 --- > 1 file changed, 3 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/in= tel_panel.c > index 18784470a760..066a66165cf1 100644 > --- a/drivers/gpu/drm/i915/intel_panel.c > +++ b/drivers/gpu/drm/i915/intel_panel.c > @@ -780,9 +780,6 @@ static void bdw_enable_backlight(struct intel_connect= or *connector) > if (panel->backlight.active_low_pwm) > pch_ctl1 |=3D BLM_PCH_POLARITY; > = > - /* BDW always uses the pch pwm controls. */ > - pch_ctl1 |=3D BLM_PCH_OVERRIDE_ENABLE; > - > I915_WRITE(BLC_PWM_PCH_CTL1, pch_ctl1); > POSTING_READ(BLC_PWM_PCH_CTL1); > I915_WRITE(BLC_PWM_PCH_CTL1, pch_ctl1 | BLM_PCH_PWM_ENABLE); > -- = > 1.9.1 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC