From mboxrd@z Thu Jan  1 00:00:00 1970
From: Damien Lespiau <damien.lespiau@intel.com>
Subject: Re: [PATCH 57/89] drm/i915: Rewrite ABS_DIFF() in a
 safer	manner
Date: Thu, 4 Sep 2014 13:32:24 +0100
Message-ID: <20140904123224.GC25664@strange.ger.corp.intel.com>
References: <1409830075-11139-1-git-send-email-damien.lespiau@intel.com>
 <1409830075-11139-58-git-send-email-damien.lespiau@intel.com>
 <874mwnfuvn.fsf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTP id B136C6E177
 for <intel-gfx@lists.freedesktop.org>; Thu,  4 Sep 2014 05:32:39 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <874mwnfuvn.fsf@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Sep 04, 2014 at 03:11:24PM +0300, Jani Nikula wrote:
> On Thu, 04 Sep 2014, Damien Lespiau <damien.lespiau@intel.com> wrote:
> > The new version of the macro does a few things better:
> >   - protect the arguments,
> >   - only evaluate the arguments once,
> >   - check that the arguments are of the same type,
> >
> > Change LC_FREQ_2K to be a unsigned 64bit constant and removed the '()'
> > from the caller as a result.
> >
> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> 
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> 
> Can be picked up for dinq separate from this series, right?

Yes, it can indeed.

-- 
Damien