From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Fix irq enable tracking in driver
	load
Date: Thu, 4 Sep 2014 15:05:01 +0200
Message-ID: <20140904130501.GL15520@phenom.ffwll.local>
References: <1409127094-5843-1-git-send-email-daniel.vetter@ffwll.ch>
 <87oauvfxmd.fsf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47])
 by gabe.freedesktop.org (Postfix) with ESMTP id 762E36E5B7
 for <intel-gfx@lists.freedesktop.org>; Thu,  4 Sep 2014 06:04:42 -0700 (PDT)
Received: by mail-wg0-f47.google.com with SMTP id z12so10113804wgg.30
 for <intel-gfx@lists.freedesktop.org>; Thu, 04 Sep 2014 06:04:41 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <87oauvfxmd.fsf@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Oliver Hartkopp <socketcan@hartkopp.net>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Sep 04, 2014 at 02:12:10PM +0300, Jani Nikula wrote:
> On Wed, 27 Aug 2014, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > A bunch of warnings fire on some ->irq_postinstall hooks since those
> > can enable interrupts (e.g. rps interrupts). And then our ordering
> > self-checks fire and complain.
> >
> > To fix that set the tracking boolen before enabling the irqs witho
> > drm_irq_install. Quoting the discussion with Jesse why that's safe:
> 
> Yi Sun's testing result needs to be addressed one way or another before
> merging this:
> 
> http://mid.gmane.org/D9F66AA509623343B6A9A3D4502D5A52112B0676@SHSMSX101.ccr.corp.intel.com

Shrug it off as an unstable test result. Both mine and Jesse's patch
really only change the logic we use to WARN about interrupt state. We
don't use pm._irqs_disabled for anything else at all.

Which means that black screen is at most a timing issue. Or the baseline
kernels don't perfectly match (the new warning in Jesse's patch is a bit
an indicator for that).
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch