From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: bdw does not have pch backlight override bit Date: Thu, 4 Sep 2014 16:07:32 +0300 Message-ID: <20140904130732.GH4193@intel.com> References: <1409831769-2926-1-git-send-email-jani.nikula@intel.com> <20140904120926.GF4193@intel.com> <87y4tzefmz.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id E4E196E547 for ; Thu, 4 Sep 2014 06:07:56 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87y4tzefmz.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Sep 04, 2014 at 03:25:56PM +0300, Jani Nikula wrote: > On Thu, 04 Sep 2014, Ville Syrj=E4l=E4 wr= ote: > > On Thu, Sep 04, 2014 at 02:56:09PM +0300, Jani Nikula wrote: > >> BDW is always in the PCH override mode, and the bit MBZ. > > > > BSpec doesn't seem to agree. In fact it says the override must be > > enabled on bdw. > = > Gah, I was looking at the skl bspec, which said bdw+. Oh well, how about > this one instead: > = > = > >From 53db5d77cf8e959ed65535f2d80f721baf74d93a Mon Sep 17 00:00:00 2001 > From: Jani Nikula > Date: Thu, 4 Sep 2014 14:54:34 +0300 > Subject: [PATCH] drm/i915: skl does not have pch backlight override bit > Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 E= spoo > Cc: Jani Nikula > = > SKL is always in the PCH override mode, and the bit MBZ. > = > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_panel.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/in= tel_panel.c > index 18784470a760..bc3e74eaf52e 100644 > --- a/drivers/gpu/drm/i915/intel_panel.c > +++ b/drivers/gpu/drm/i915/intel_panel.c > @@ -781,7 +781,8 @@ static void bdw_enable_backlight(struct intel_connect= or *connector) > pch_ctl1 |=3D BLM_PCH_POLARITY; > = > /* BDW always uses the pch pwm controls. */ > - pch_ctl1 |=3D BLM_PCH_OVERRIDE_ENABLE; > + if (IS_BROADWELL(dev)) > + pch_ctl1 |=3D BLM_PCH_OVERRIDE_ENABLE; I guess this should really check for the PCH version instead. I'm slightly concerned about early SKLs being equipped with WPT where this might cause problems. > = > I915_WRITE(BLC_PWM_PCH_CTL1, pch_ctl1); > POSTING_READ(BLC_PWM_PCH_CTL1); > -- = > 1.9.1 > = > = > = > = > > > >> = > >> Signed-off-by: Jani Nikula > >> --- > >> drivers/gpu/drm/i915/intel_panel.c | 3 --- > >> 1 file changed, 3 deletions(-) > >> = > >> diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915= /intel_panel.c > >> index 18784470a760..066a66165cf1 100644 > >> --- a/drivers/gpu/drm/i915/intel_panel.c > >> +++ b/drivers/gpu/drm/i915/intel_panel.c > >> @@ -780,9 +780,6 @@ static void bdw_enable_backlight(struct intel_conn= ector *connector) > >> if (panel->backlight.active_low_pwm) > >> pch_ctl1 |=3D BLM_PCH_POLARITY; > >> = > >> - /* BDW always uses the pch pwm controls. */ > >> - pch_ctl1 |=3D BLM_PCH_OVERRIDE_ENABLE; > >> - > >> I915_WRITE(BLC_PWM_PCH_CTL1, pch_ctl1); > >> POSTING_READ(BLC_PWM_PCH_CTL1); > >> I915_WRITE(BLC_PWM_PCH_CTL1, pch_ctl1 | BLM_PCH_PWM_ENABLE); > >> -- = > >> 1.9.1 > >> = > >> _______________________________________________ > >> Intel-gfx mailing list > >> Intel-gfx@lists.freedesktop.org > >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > > > -- = > > Ville Syrj=E4l=E4 > > Intel OTC > = > -- = > Jani Nikula, Intel Open Source Technology Center -- = Ville Syrj=E4l=E4 Intel OTC