From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 77/89] drm/i915: Introduce a
 for_each_plane() macro
Date: Thu, 4 Sep 2014 16:00:32 +0200
Message-ID: <20140904140032.GV15520@phenom.ffwll.local>
References: <1409830075-11139-1-git-send-email-damien.lespiau@intel.com>
 <1409830075-11139-78-git-send-email-damien.lespiau@intel.com>
 <20140904133247.GB13230@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52])
 by gabe.freedesktop.org (Postfix) with ESMTP id 2AE576E6C9
 for <intel-gfx@lists.freedesktop.org>; Thu,  4 Sep 2014 07:00:12 -0700 (PDT)
Received: by mail-wg0-f52.google.com with SMTP id m15so10041296wgh.11
 for <intel-gfx@lists.freedesktop.org>; Thu, 04 Sep 2014 07:00:11 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140904133247.GB13230@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, Damien Lespiau <damien.lespiau@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Sep 04, 2014 at 02:32:47PM +0100, Chris Wilson wrote:
> On Thu, Sep 04, 2014 at 12:27:43PM +0100, Damien Lespiau wrote:
> > Tired of copy/pasting things around.
> > 
> > v2: Rebase on top of the for_each_pipe() change adding dev_priv as first
> >     argument.
> > 
> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> > ---
> >  drivers/gpu/drm/i915/i915_drv.h | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> > index 91ea2b7..95e57dc 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -176,6 +176,8 @@ enum hpd_pin {
> >  
> >  #define for_each_pipe(__dev_priv, __p) \
> >  	for ((__p) = 0; (__p) < INTEL_INFO(__dev_priv)->num_pipes; (__p)++)
> > +#define for_each_plane(pipe, p) \
> > +	for ((p) = 0; (p) < INTEL_INFO(dev)->num_sprites[(pipe)] + 1; (p)++)
> 
> We are adding new magic macros taking dev...
> 
> >  #define for_each_sprite(p, s) for ((s) = 0; (s) < INTEL_INFO(dev)->num_sprites[(p)]; (s)++)
> I haven't asked you to fix this one yet either.

Ok, dropping again for now ...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch