From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH 77/89] drm/i915: Introduce a for_each_plane() macro Date: Thu, 4 Sep 2014 15:02:33 +0100 Message-ID: <20140904140233.GA14301@strange.ger.corp.intel.com> References: <1409830075-11139-1-git-send-email-damien.lespiau@intel.com> <1409830075-11139-78-git-send-email-damien.lespiau@intel.com> <20140904133247.GB13230@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id F2FBB6E6F9 for ; Thu, 4 Sep 2014 07:03:39 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140904133247.GB13230@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Sep 04, 2014 at 02:32:47PM +0100, Chris Wilson wrote: > > +#define for_each_plane(pipe, p) \ > > + for ((p) = 0; (p) < INTEL_INFO(dev)->num_sprites[(pipe)] + 1; (p)++) > > We are adding new magic macros taking dev... > > > #define for_each_sprite(p, s) for ((s) = 0; (s) < INTEL_INFO(dev)->num_sprites[(p)]; (s)++) > I haven't asked you to fix this one yet either. I hereby promise I'll add those dev_priv arguments as followup up patches. -- Damien