public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Daniel Vetter <daniel@ffwll.ch>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Convert hangcheck from a timer into a	delayed work item
Date: Thu, 4 Sep 2014 16:12:43 +0200	[thread overview]
Message-ID: <20140904141243.GW15520@phenom.ffwll.local> (raw)
In-Reply-To: <20140904133344.GC13230@nuc-i3427.alporthouse.com>

On Thu, Sep 04, 2014 at 02:33:44PM +0100, Chris Wilson wrote:
> On Thu, Sep 04, 2014 at 03:31:14PM +0200, Daniel Vetter wrote:
> > Didn't 3.17 just gain the mod_delayed_work interface?
> 
> Yes. It was so exciting and doesn't appear to requeue.

I guess we could do the mod_delayed_work in add_request and use the
schedule_delayed_work everywhere in i915_irq.c then?

But when exactly does mod_delayed_work not requeue? Documentation at
least claims it does ...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

  reply	other threads:[~2014-09-04 14:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-04 12:04 [PATCH] drm/i915: Convert hangcheck from a timer into a delayed work item Chris Wilson
2014-09-04 12:17 ` Jani Nikula
2014-09-04 12:26   ` Chris Wilson
2014-09-04 13:31     ` Daniel Vetter
2014-09-04 13:33       ` Chris Wilson
2014-09-04 14:12         ` Daniel Vetter [this message]
2014-09-04 14:18           ` Chris Wilson
2014-09-04 15:09 ` Chris Wilson
2014-09-04 15:25   ` Ville Syrjälä
2014-09-04 15:38     ` Chris Wilson
2014-09-04 16:40       ` Ville Syrjälä
2014-10-07 15:34   ` Mika Kuoppala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140904141243.GW15520@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox