From: Daniel Vetter <daniel@ffwll.ch>
To: "Chris Wilson" <chris@chris-wilson.co.uk>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org,
"Daniel Vetter" <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 02/10] drm/i915: Decouple the stuck pageflip on modeset
Date: Fri, 5 Sep 2014 10:51:48 +0200 [thread overview]
Message-ID: <20140905085148.GH15520@phenom.ffwll.local> (raw)
In-Reply-To: <20140905073120.GF13230@nuc-i3427.alporthouse.com>
On Fri, Sep 05, 2014 at 08:31:20AM +0100, Chris Wilson wrote:
> On Fri, Sep 05, 2014 at 09:27:16AM +0200, Daniel Vetter wrote:
> > On Thu, Sep 04, 2014 at 08:15:32PM +0300, Ville Syrjälä wrote:
> > > On Tue, Sep 02, 2014 at 02:57:37PM +0100, Chris Wilson wrote:
> > > > If we successfully confuse the hardware, and cause it to drop a queued
> > > > pageflip, we wait for 60s and issue a warning before continuing on with
> > > > the modeset. However, this leaves the pending pageflip still stuck
> > > > indefinitely. Pretend to userspace that it does complete, and let us
> > > > start afresh following the modeset.
> > > >
> > > > v2: Rebase after refactor
> >
> > This applied cleanly despite that I don't have that refactor. Should I be
> > concerned?
>
> No, the refactoring here was about the pageflip checking itself in patch
> 1. I just kept moving these two in lockstep.
Yeah, serious lack of coffee when I tried to apply this ;-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-09-05 8:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 13:57 [PATCH 01/10] drm/i915: Check for a stalled page flip after each vblank Chris Wilson
2014-09-02 13:57 ` [PATCH 02/10] drm/i915: Decouple the stuck pageflip on modeset Chris Wilson
2014-09-04 17:15 ` Ville Syrjälä
2014-09-05 7:27 ` Daniel Vetter
2014-09-05 7:31 ` Chris Wilson
2014-09-05 8:51 ` Daniel Vetter [this message]
2014-09-02 13:57 ` [PATCH 03/10] drm/i915: Boost GPU frequency if we detect outstanding pageflips Chris Wilson
2014-09-02 13:57 ` [PATCH 04/10] drm/i915: Deminish contribution of wait-boosting from clients Chris Wilson
2014-09-02 13:57 ` [PATCH 05/10] drm/i915: Relax RPS contraints to allows setting minfreq on idle Chris Wilson
2014-09-02 13:57 ` [PATCH 06/10] drm/i915: Rearrange RPS frequency calculation Chris Wilson
2014-09-02 13:57 ` [PATCH 07/10] drm/i915: Improved w/a for rps on Baytrail Chris Wilson
2014-09-02 13:57 ` [PATCH 08/10] drm/i915: Use down ei for manual Baytrail RPS calculations Chris Wilson
2014-09-02 13:57 ` [PATCH 09/10] drm/i915: Agressive downclocking on Baytrail Chris Wilson
2014-09-02 13:57 ` [PATCH 10/10] drm/i915: Move pm_rps_events to i915->rps Chris Wilson
2014-09-02 14:31 ` [PATCH 01/10] drm/i915: Check for a stalled page flip after each vblank Ville Syrjälä
2014-09-02 14:36 ` Chris Wilson
2014-09-02 14:52 ` Daniel Vetter
2014-09-02 15:07 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140905085148.GH15520@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox