From: Daniel Vetter <daniel@ffwll.ch>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH] drm/i915: FBC flush nuke for BDW
Date: Mon, 8 Sep 2014 09:29:04 +0200 [thread overview]
Message-ID: <20140908072904.GL15520@phenom.ffwll.local> (raw)
In-Reply-To: <CABVU7+u0x4sgw0=Q98gUhi5-A+zqS3i=GmaTYNrSdYsiRRTZqg@mail.gmail.com>
On Fri, Sep 05, 2014 at 02:12:49PM -0700, Rodrigo Vivi wrote:
> As Paulo told the part 2 of his proposal is still missing and we will get
> the WARN of reading fbc register at fbc_enabled when on runtime_suspend...
>
> But I couldn't find the propper place to check for intel_crtc->active. This
> was another issue reported by power team that on screen off there was to
> much activity on our driver. So we need to check it more carefully the
> proper place to avoid all unecessary inactivities with display off.
>
> Do you have any suggestion Daniel?
Don't check for intel->active since doing that will lead to hilarious
locking inversions. You have to add a bit of tracking (with it's own
locking) for which frontbuffer events are interesting for fbc like psr
does. Since we only do fbc on one plane ever that's only ever going to be
one bit, but setting/clearing it correctly in crtc_enable/disable is the
important part here.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-09-08 7:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 16:26 [PATCH 1/2] drm/i915: Introduce FBC False Color for debug purposes Rodrigo Vivi
2014-07-30 16:26 ` [PATCH 2/2] drm/i915: FBC flush nuke for BDW Rodrigo Vivi
2014-07-31 19:07 ` [PATCH] " Rodrigo Vivi
2014-08-01 14:07 ` Ville Syrjälä
2014-08-04 8:11 ` Daniel Vetter
2014-08-04 10:51 ` Rodrigo Vivi
2014-08-07 20:04 ` Rodrigo Vivi
2014-08-08 7:06 ` Daniel Vetter
[not found] ` <CABVU7+tzGz9DaKiyg_KBegcrOWhXmHWD0xGjcaRpWHGyzRcjsA@mail.gmail.com>
[not found] ` <CAKMK7uH-PipHvNFNmgD4=_W=AhmcDVejf8MN6D9-17K4nLsDzw@mail.gmail.com>
2014-08-19 18:58 ` Daniel Vetter
2014-08-21 16:44 ` Rodrigo Vivi
2014-08-26 0:39 ` Rodrigo Vivi
2014-08-26 7:54 ` Daniel Vetter
2014-08-26 18:38 ` Rodrigo Vivi
2014-08-26 20:43 ` Daniel Vetter
2014-09-05 18:28 ` Paulo Zanoni
2014-09-05 19:35 ` Rodrigo Vivi
2014-09-05 21:12 ` Rodrigo Vivi
2014-09-08 7:29 ` Daniel Vetter [this message]
2014-09-08 7:26 ` Daniel Vetter
2014-07-31 4:01 ` [PATCH 1/2] drm/i915: Introduce FBC False Color for debug purposes Ben Widawsky
2014-07-31 19:07 ` [PATCH] " Rodrigo Vivi
2014-08-01 10:27 ` Ville Syrjälä
2014-08-01 9:04 ` Rodrigo Vivi
2014-08-04 8:14 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140908072904.GL15520@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@gmail.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox