From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 13/16] drm/i915: Fix DVO 2x clock enable on 830M Date: Mon, 8 Sep 2014 09:33:12 +0200 Message-ID: <20140908073312.GM15520@phenom.ffwll.local> References: <1408054928-24141-14-git-send-email-ville.syrjala@linux.intel.com> <1409943162-26469-1-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by gabe.freedesktop.org (Postfix) with ESMTP id F1B6A89216 for ; Mon, 8 Sep 2014 00:32:46 -0700 (PDT) Received: by mail-wi0-f174.google.com with SMTP id d1so2091090wiv.7 for ; Mon, 08 Sep 2014 00:32:46 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1409943162-26469-1-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com Cc: Thomas Richter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBTZXAgMDUsIDIwMTQgYXQgMDk6NTI6NDJQTSArMDMwMCwgdmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20gd3JvdGU6Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBUaGUgc3BlYyBzYXlzOgo+ICJGb3IgdGhlIGNvcnJl Y3Qgb3BlcmF0aW9uIG9mIHRoZSBtdXhlZCBEVk8gcGlucyAoR0RFVlNFTEIvIEkyQ2RhdGEsCj4g R0lSREJZL0kyQ0NsaykgYW5kIChHRlJBTUVCL0RWSV9EYXRhLCBHVFJEWUIvRFZJX0Nsayk6IEJp dCAzMQo+IChEUExMIFZDTyBFbmFibGUpIGFuZCBCaXQgMzAgKDJYIENsb2NrIEVuYWJsZSkgbXVz dCBiZSBzZXQgdG8g4oCcMeKAnSBpbgo+IGJvdGggdGhlIERQTEwgQSBDb250cm9sIFJlZ2lzdGVy ICgwNjAxNGgtMDYwMTdoKSBhbmQgRFBMTCBCIENvbnRyb2wKPiBSZWdpc3RlciAoMDYwMThoLTA2 MDFCaCkuIgo+IAo+IFRoZSBwaXBlIEEgYW5kIEIgZm9yY2UgcXVpcmtzIHRha2UgY2FyZSBvZiBE UExMX1ZDT19FTkFCTEUsIHNvIHdlCj4ganVzdCBuZWVkIGEgYml0IG9mIHNwZWNpYWwgY2FyZSB0 byBoYW5kbGUgRFBMTF9EVk9fMlhfTU9ERS4KPiAKPiB2MjogUmVjb21wdXRlIG51bV9kdm9fcGlw ZXMgb24gdGhlIHNwb3QsIHVzZSBQSVBFX0EvUElQRV9CIGluc3RlYWQKPiAgICAgb2YgcGlwZS8h cGlwZSBmb3IgdGhlIHJlZ2lzdGVyIG9mZnNldHMgaW4gZGlzYWJsZSAoRGFuaWVsKQo+ICAgICBB ZGQgYSBjb21tZW50IGFib3V0IHRoZSBvcmRlcmluZyBpbiBlbmFibGUgYW5kIGFub3RoZXIgb25l Cj4gICAgIGFib3V0IGZpbHRlcmluZyBvdXQgdGhlIERWTyAyeCBiaXQgaW4gc3RhdGUgcmVhZG91 dAo+IAo+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51 eC5pbnRlbC5jb20+CgpRdWV1ZWQgZm9yIC1uZXh0LCB0aGFua3MgZm9yIHRoZSBwYXRjaC4KLURh bmllbAoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgNTMg KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA0 OSBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kaXNwbGF5LmMKPiBpbmRleCA4NDJhNWUxLi42ZDYyMTRhIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC0xNjEyLDYgKzE2MTIsMTggQEAgc3RhdGljIHZvaWQg Y2h2X2VuYWJsZV9wbGwoc3RydWN0IGludGVsX2NydGMgKmNydGMpCj4gIAltdXRleF91bmxvY2so JmRldl9wcml2LT5kcGlvX2xvY2spOwo+ICB9Cj4gIAo+ICtzdGF0aWMgaW50IGludGVsX251bV9k dm9fcGlwZXMoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiArewo+ICsJc3RydWN0IGludGVsX2Ny dGMgKmNydGM7Cj4gKwlpbnQgY291bnQgPSAwOwo+ICsKPiArCWZvcl9lYWNoX2ludGVsX2NydGMo ZGV2LCBjcnRjKQo+ICsJCWNvdW50ICs9IGNydGMtPmFjdGl2ZSAmJgo+ICsJCQlpbnRlbF9waXBl X2hhc190eXBlKCZjcnRjLT5iYXNlLCBJTlRFTF9PVVRQVVRfRFZPKTsKPiArCj4gKwlyZXR1cm4g Y291bnQ7Cj4gK30KPiArCj4gIHN0YXRpYyB2b2lkIGk5eHhfZW5hYmxlX3BsbChzdHJ1Y3QgaW50 ZWxfY3J0YyAqY3J0YykKPiAgewo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGNydGMtPmJh c2UuZGV2Owo+IEBAIC0xNjI4LDcgKzE2NDAsMTggQEAgc3RhdGljIHZvaWQgaTl4eF9lbmFibGVf cGxsKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+ICAJaWYgKElTX01PQklMRShkZXYpICYmICFJ U19JODMwKGRldikpCj4gIAkJYXNzZXJ0X3BhbmVsX3VubG9ja2VkKGRldl9wcml2LCBjcnRjLT5w aXBlKTsKPiAgCj4gLQlJOTE1X1dSSVRFKHJlZywgZHBsbCk7Cj4gKwkvKiBFbmFibGUgRFZPIDJ4 IGNsb2NrIG9uIGJvdGggUExMcyBpZiBuZWNlc3NhcnkgKi8KPiArCWlmIChJU19JODMwKGRldikg JiYgaW50ZWxfbnVtX2R2b19waXBlcyhkZXYpID4gMCkgewo+ICsJCS8qCj4gKwkJICogSXQgYXBw ZWFycyB0byBiZSBpbXBvcnRhbnQgdGhhdCB3ZSBkb24ndCBlbmFibGUgdGhpcwo+ICsJCSAqIGZv ciB0aGUgY3VycmVudCBwaXBlIGJlZm9yZSBvdGhlcndpc2UgY29uZmlndXJpbmcgdGhlCj4gKwkJ ICogUExMLiBObyBpZGVhIGhvdyB0aGlzIHNob3VsZCBiZSBoYW5kbGVkIGlmIG11bHRpcGxlCj4g KwkJICogRFZPIG91dHB1dHMgYXJlIGVuYWJsZWQgc2ltdWx0YW5lb3NseS4KPiArCQkgKi8KPiAr CQlkcGxsIHw9IERQTExfRFZPXzJYX01PREU7Cj4gKwkJSTkxNV9XUklURShEUExMKCFjcnRjLT5w aXBlKSwKPiArCQkJICAgSTkxNV9SRUFEKERQTEwoIWNydGMtPnBpcGUpKSB8IERQTExfRFZPXzJY X01PREUpOwo+ICsJfQo+ICAKPiAgCS8qIFdhaXQgZm9yIHRoZSBjbG9ja3MgdG8gc3RhYmlsaXpl LiAqLwo+ICAJUE9TVElOR19SRUFEKHJlZyk7Cj4gQEAgLTE2NjcsOCArMTY5MCwyMiBAQCBzdGF0 aWMgdm9pZCBpOXh4X2VuYWJsZV9wbGwoc3RydWN0IGludGVsX2NydGMgKmNydGMpCj4gICAqCj4g ICAqIE5vdGUhICBUaGlzIGlzIGZvciBwcmUtSUxLIG9ubHkuCj4gICAqLwo+IC1zdGF0aWMgdm9p ZCBpOXh4X2Rpc2FibGVfcGxsKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgZW51 bSBwaXBlIHBpcGUpCj4gK3N0YXRpYyB2b2lkIGk5eHhfZGlzYWJsZV9wbGwoc3RydWN0IGludGVs X2NydGMgKmNydGMpCj4gIHsKPiArCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBjcnRjLT5iYXNl LmRldjsKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3By aXZhdGU7Cj4gKwllbnVtIHBpcGUgcGlwZSA9IGNydGMtPnBpcGU7Cj4gKwo+ICsJLyogRGlzYWJs ZSBEVk8gMnggY2xvY2sgb24gYm90aCBQTExzIGlmIG5lY2Vzc2FyeSAqLwo+ICsJaWYgKElTX0k4 MzAoZGV2KSAmJgo+ICsJICAgIGludGVsX3BpcGVfaGFzX3R5cGUoJmNydGMtPmJhc2UsIElOVEVM X09VVFBVVF9EVk8pICYmCj4gKwkgICAgaW50ZWxfbnVtX2R2b19waXBlcyhkZXYpID09IDEpIHsK PiArCQlJOTE1X1dSSVRFKERQTEwoUElQRV9CKSwKPiArCQkJICAgSTkxNV9SRUFEKERQTEwoUElQ RV9CKSkgJiB+RFBMTF9EVk9fMlhfTU9ERSk7Cj4gKwkJSTkxNV9XUklURShEUExMKFBJUEVfQSks Cj4gKwkJCSAgIEk5MTVfUkVBRChEUExMKFBJUEVfQSkpICYgfkRQTExfRFZPXzJYX01PREUpOwo+ ICsJfQo+ICsKPiAgCS8qIERvbid0IGRpc2FibGUgcGlwZSBvciBwaXBlIFBMTHMgaWYgbmVlZGVk ICovCj4gIAlpZiAoKHBpcGUgPT0gUElQRV9BICYmIGRldl9wcml2LT5xdWlya3MgJiBRVUlSS19Q SVBFQV9GT1JDRSkgfHwKPiAgCSAgICAocGlwZSA9PSBQSVBFX0IgJiYgZGV2X3ByaXYtPnF1aXJr cyAmIFFVSVJLX1BJUEVCX0ZPUkNFKSkKPiBAQCAtNDk0MCw3ICs0OTc3LDcgQEAgc3RhdGljIHZv aWQgaTl4eF9jcnRjX2Rpc2FibGUoc3RydWN0IGRybV9jcnRjICpjcnRjKQo+ICAJCWVsc2UgaWYg KElTX1ZBTExFWVZJRVcoZGV2KSkKPiAgCQkJdmx2X2Rpc2FibGVfcGxsKGRldl9wcml2LCBwaXBl KTsKPiAgCQllbHNlCj4gLQkJCWk5eHhfZGlzYWJsZV9wbGwoZGV2X3ByaXYsIHBpcGUpOwo+ICsJ CQlpOXh4X2Rpc2FibGVfcGxsKGludGVsX2NydGMpOwo+ICAJfQo+ICAKPiAgCWlmICghSVNfR0VO MihkZXYpKQo+IEBAIC01OTQ0LDcgKzU5ODEsNyBAQCBzdGF0aWMgdm9pZCBpOHh4X3VwZGF0ZV9w bGwoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gIAkJCWRwbGwgfD0gUExMX1AyX0RJVklERV9C WV80Owo+ICAJfQo+ICAKPiAtCWlmIChpbnRlbF9waXBlX2hhc190eXBlKCZjcnRjLT5iYXNlLCBJ TlRFTF9PVVRQVVRfRFZPKSkKPiArCWlmICghSVNfSTgzMChkZXYpICYmIGludGVsX3BpcGVfaGFz X3R5cGUoJmNydGMtPmJhc2UsIElOVEVMX09VVFBVVF9EVk8pKQo+ICAJCWRwbGwgfD0gRFBMTF9E Vk9fMlhfTU9ERTsKPiAgCj4gIAlpZiAoaW50ZWxfcGlwZV9oYXNfdHlwZSgmY3J0Yy0+YmFzZSwg SU5URUxfT1VUUFVUX0xWRFMpICYmCj4gQEAgLTY0NTAsNiArNjQ4NywxNCBAQCBzdGF0aWMgYm9v bCBpOXh4X2dldF9waXBlX2NvbmZpZyhzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiAgCX0KPiAg CXBpcGVfY29uZmlnLT5kcGxsX2h3X3N0YXRlLmRwbGwgPSBJOTE1X1JFQUQoRFBMTChjcnRjLT5w aXBlKSk7Cj4gIAlpZiAoIUlTX1ZBTExFWVZJRVcoZGV2KSkgewo+ICsJCS8qCj4gKwkJICogRFBM TF9EVk9fMlhfTU9ERSBtdXN0IGJlIGVuYWJsZWQgZm9yIGJvdGggRFBMTHMKPiArCQkgKiBvbiA4 MzAuIEZpbHRlciBpdCBvdXQgaGVyZSBzbyB0aGF0IHdlIGRvbid0Cj4gKwkJICogcmVwb3J0IGVy cm9ycyBkdWUgdG8gdGhhdC4KPiArCQkgKi8KPiArCQlpZiAoSVNfSTgzMChkZXYpKQo+ICsJCQlw aXBlX2NvbmZpZy0+ZHBsbF9od19zdGF0ZS5kcGxsICY9IH5EUExMX0RWT18yWF9NT0RFOwo+ICsK PiAgCQlwaXBlX2NvbmZpZy0+ZHBsbF9od19zdGF0ZS5mcDAgPSBJOTE1X1JFQUQoRlAwKGNydGMt PnBpcGUpKTsKPiAgCQlwaXBlX2NvbmZpZy0+ZHBsbF9od19zdGF0ZS5mcDEgPSBJOTE1X1JFQUQo RlAxKGNydGMtPnBpcGUpKTsKPiAgCX0gZWxzZSB7Cj4gLS0gCj4gMS44LjUuNQo+IAoKLS0gCkRh bmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCis0MSAoMCkg NzkgMzY1IDU3IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK