From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH -v4 0/4] split plane's updates functions
 into check() and commit()
Date: Mon, 8 Sep 2014 16:59:42 +0300
Message-ID: <20140908135942.GY4193@intel.com>
References: <1409947489-2667-1-git-send-email-gustavo@padovan.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <1409947489-2667-1-git-send-email-gustavo@padovan.org>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Gustavo Padovan <gustavo@padovan.org>
Cc: intel-gfx@lists.freedesktop.org, Gustavo Padovan <gustavo.padovan@collabora.co.uk>, dri-devel@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Sep 05, 2014 at 05:04:45PM -0300, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> =

> This is the beginning of the work to prepare i915 for the upcoming
> atomic modesetting API. Here we split the plane update fucntions in
> the check and commit states.
> =

> v2: use struct intel_plane_state to keep states between check and
> commit stages.
> =

> v3: take Ville's comments:
>         - rename pstate to state
>         - get rid of non-drm_rect coordinates in intel_plane_state
>         - keep 'clip' const
> =

> v4: take more Ville's comments:
> 	- populates orig_dst and orig_src too
> 	- use orig_dst coordinates to program the cursor plane
> =

> Gustavo Padovan (4):
>   drm/i915: create struct intel_plane_state
>   drm/i915: split intel_update_plane into check() and commit()
>   drm/i915: split intel_cursor_plane_update() into check() and commit()
>   drm/i915: split intel_primary_plane_setplane() into check() and
>     commit()

It's looking pretty nice. I didn't spot any more problems, so for the
series:
Reviewed-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>

> =

>  drivers/gpu/drm/i915/intel_display.c | 240 +++++++++++++++++++++--------=
------
>  drivers/gpu/drm/i915/intel_drv.h     |  12 ++
>  drivers/gpu/drm/i915/intel_sprite.c  | 233 ++++++++++++++++++++---------=
-----
>  3 files changed, 298 insertions(+), 187 deletions(-)
> =

> -- =

> 1.9.3
> =

> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- =

Ville Syrj=E4l=E4
Intel OTC