From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [Intel-gfx] [PATCH -v4 0/4] split plane's updates functions into
 check() and commit()
Date: Mon, 8 Sep 2014 18:32:57 +0200
Message-ID: <20140908163257.GD15520@phenom.ffwll.local>
References: <1409947489-2667-1-git-send-email-gustavo@padovan.org>
 <20140908135942.GY4193@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20140908135942.GY4193@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, Gustavo Padovan <gustavo.padovan@collabora.co.uk>, dri-devel@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Mon, Sep 08, 2014 at 04:59:42PM +0300, Ville Syrj=E4l=E4 wrote:
> On Fri, Sep 05, 2014 at 05:04:45PM -0300, Gustavo Padovan wrote:
> > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > =

> > This is the beginning of the work to prepare i915 for the upcoming
> > atomic modesetting API. Here we split the plane update fucntions in
> > the check and commit states.
> > =

> > v2: use struct intel_plane_state to keep states between check and
> > commit stages.
> > =

> > v3: take Ville's comments:
> >         - rename pstate to state
> >         - get rid of non-drm_rect coordinates in intel_plane_state
> >         - keep 'clip' const
> > =

> > v4: take more Ville's comments:
> > 	- populates orig_dst and orig_src too
> > 	- use orig_dst coordinates to program the cursor plane
> > =

> > Gustavo Padovan (4):
> >   drm/i915: create struct intel_plane_state
> >   drm/i915: split intel_update_plane into check() and commit()
> >   drm/i915: split intel_cursor_plane_update() into check() and commit()
> >   drm/i915: split intel_primary_plane_setplane() into check() and
> >     commit()
> =

> It's looking pretty nice. I didn't spot any more problems, so for the
> series:
> Reviewed-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>

Queued for -next, thanks for the patch.
-Daniel

> =

> > =

> >  drivers/gpu/drm/i915/intel_display.c | 240 +++++++++++++++++++++------=
--------
> >  drivers/gpu/drm/i915/intel_drv.h     |  12 ++
> >  drivers/gpu/drm/i915/intel_sprite.c  | 233 ++++++++++++++++++++-------=
-------
> >  3 files changed, 298 insertions(+), 187 deletions(-)
> > =

> > -- =

> > 1.9.3
> > =

> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> =

> -- =

> Ville Syrj=E4l=E4
> Intel OTC
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch