From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, Thomas Wood <thomas.wood@intel.com>
Subject: Re: [PATCH i-g-t v2 5/6] lib: don't force HDMI or DP connectors on gen 7 and 8
Date: Tue, 9 Sep 2014 15:42:06 +0300 [thread overview]
Message-ID: <20140909124206.GF4193@intel.com> (raw)
In-Reply-To: <20140905121508.GI15520@phenom.ffwll.local>
On Fri, Sep 05, 2014 at 02:15:08PM +0200, Daniel Vetter wrote:
> On Fri, Sep 05, 2014 at 10:52:08AM +0100, Thomas Wood wrote:
> > Forcing HDMI or DP connectors on gen 7 and 8 doesn't currently work, so
> > fail early to allow the test to skip if required.
> >
> > Signed-off-by: Thomas Wood <thomas.wood@intel.com>
> > ---
> > lib/igt_kms.c | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> > index 0dc46f9..e9455aa 100644
> > --- a/lib/igt_kms.c
> > +++ b/lib/igt_kms.c
> > @@ -41,6 +41,7 @@
> > #include "drmtest.h"
> > #include "igt_kms.h"
> > #include "igt_aux.h"
> > +#include "intel_chipset.h"
> >
> > /*
> > * There hasn't been a release of libdrm containing these #define's yet, so
> > @@ -344,6 +345,17 @@ bool kmstest_force_connector(int drm_fd, drmModeConnector *connector,
> > char *path;
> > const char *value;
> > int debugfs_fd, ret;
> > + uint32_t devid;
> > +
> > + devid = intel_get_drm_devid(drm_fd);
> > +
> > + /* forcing hdmi or dp connectors on gen 7 and 8 doesn't currently work,
> > + * so fail early to allow the test to skip if required */
> > + if ((connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
> > + connector->connector_type == DRM_MODE_CONNECTOR_HDMIB ||
> > + connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort)
> > + && (IS_GEN7(devid) || IS_GEN8(devid)))
>
> This catches too many platforms, since on ivb, vlv and chv we _can_
> already use this.
That's a bit of an overstatement. Maybe someone wants to review this?
http://lists.freedesktop.org/archives/intel-gfx/2014-May/045564.html
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2014-09-09 12:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 10:54 [PATCH i-g-t 1/3] lib: add kmstest_edid_add_3d Thomas Wood
2014-08-20 10:54 ` [PATCH i-g-t 2/3] lib: move create_stereo_fb from testdisplay to igt_fb Thomas Wood
2014-08-20 10:54 ` [PATCH i-g-t 3/3] tests: add kms_3d test Thomas Wood
2014-08-26 13:38 ` Damien Lespiau
2014-08-26 13:43 ` [PATCH i-g-t 1/3] lib: add kmstest_edid_add_3d Damien Lespiau
2014-09-04 19:57 ` Clint Taylor
2014-09-05 9:52 ` [PATCH i-g-t v2 0/6] 3D stereo mode testing Thomas Wood
2014-09-05 9:52 ` [PATCH i-g-t v2 1/6] lib: add kmstest_edid_add_3d Thomas Wood
2014-09-05 9:52 ` [PATCH i-g-t v2 2/6] lib: move create_stereo_fb from testdisplay to igt_fb Thomas Wood
2014-09-05 9:52 ` [PATCH i-g-t v2 3/6] tests: add kms_3d test Thomas Wood
2014-09-05 9:52 ` [PATCH i-g-t v2 4/6] lib/igt_fb: ensure igt_create_fb parameters are consistent Thomas Wood
2014-09-05 9:52 ` [PATCH i-g-t v2 5/6] lib: don't force HDMI or DP connectors on gen 7 and 8 Thomas Wood
2014-09-05 12:15 ` Daniel Vetter
2014-09-09 12:42 ` Ville Syrjälä [this message]
2014-09-05 9:52 ` [PATCH i-g-t v2 6/6] tests/kms_3d: skip if connectors cannot be forced Thomas Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909124206.GF4193@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=thomas.wood@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox