From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH i-g-t v2 5/6] lib: don't force HDMI or DP connectors on gen 7 and 8 Date: Tue, 9 Sep 2014 15:42:06 +0300 Message-ID: <20140909124206.GF4193@intel.com> References: <5408C410.8080500@intel.com> <1409910729-13485-1-git-send-email-thomas.wood@intel.com> <1409910729-13485-6-git-send-email-thomas.wood@intel.com> <20140905121508.GI15520@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 770AC89CC1 for ; Tue, 9 Sep 2014 05:42:11 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140905121508.GI15520@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, Thomas Wood List-Id: intel-gfx@lists.freedesktop.org On Fri, Sep 05, 2014 at 02:15:08PM +0200, Daniel Vetter wrote: > On Fri, Sep 05, 2014 at 10:52:08AM +0100, Thomas Wood wrote: > > Forcing HDMI or DP connectors on gen 7 and 8 doesn't currently work, so > > fail early to allow the test to skip if required. > > = > > Signed-off-by: Thomas Wood > > --- > > lib/igt_kms.c | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > = > > diff --git a/lib/igt_kms.c b/lib/igt_kms.c > > index 0dc46f9..e9455aa 100644 > > --- a/lib/igt_kms.c > > +++ b/lib/igt_kms.c > > @@ -41,6 +41,7 @@ > > #include "drmtest.h" > > #include "igt_kms.h" > > #include "igt_aux.h" > > +#include "intel_chipset.h" > > = > > /* > > * There hasn't been a release of libdrm containing these #define's ye= t, so > > @@ -344,6 +345,17 @@ bool kmstest_force_connector(int drm_fd, drmModeCo= nnector *connector, > > char *path; > > const char *value; > > int debugfs_fd, ret; > > + uint32_t devid; > > + > > + devid =3D intel_get_drm_devid(drm_fd); > > + > > + /* forcing hdmi or dp connectors on gen 7 and 8 doesn't currently wor= k, > > + * so fail early to allow the test to skip if required */ > > + if ((connector->connector_type =3D=3D DRM_MODE_CONNECTOR_HDMIA || > > + connector->connector_type =3D=3D DRM_MODE_CONNECTOR_HDMIB || > > + connector->connector_type =3D=3D DRM_MODE_CONNECTOR_DisplayPort) > > + && (IS_GEN7(devid) || IS_GEN8(devid))) > = > This catches too many platforms, since on ivb, vlv and chv we _can_ > already use this. That's a bit of an overstatement. Maybe someone wants to review this? http://lists.freedesktop.org/archives/intel-gfx/2014-May/045564.html -- = Ville Syrj=E4l=E4 Intel OTC