From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Don't reinit hpd interrupts after
	gpu reset
Date: Tue, 9 Sep 2014 16:03:15 +0300
Message-ID: <20140909130315.GG4193@intel.com>
References: <1410193038-328-1-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTP id D3C6C89518
 for <intel-gfx@lists.freedesktop.org>; Tue,  9 Sep 2014 06:04:19 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1410193038-328-1-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Mon, Sep 08, 2014 at 06:17:18PM +0200, Daniel Vetter wrote:
> Somehow I've overlooked this when simplifying the irq reinit
> scheme on gen4.5+ in
> =

> commit 78ad455fd229c6f6cc2f390ccbe0d8f1a62d55a9
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date:   Thu May 22 22:18:21 2014 +0200
> =

>     drm/i915: Improve irq handling after gpu resets
> =

> Since display interrups in general survive a gpu reset on those
> platforms there's also no need to reinit the hotplug settings.
> =

> Cc: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

This matches my observations on actual hardware. IIRC I looked at the
reset vs. interrupt registers at least on ILK and IVB and the registers
retained their current values on both.

Reviewed-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/i915_drv.c | 2 --
>  1 file changed, 2 deletions(-)
> =

> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_=
drv.c
> index 8ff375538b5d..70cc38924040 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -871,8 +871,6 @@ int i915_reset(struct drm_device *dev)
>  		 */
>  		if (INTEL_INFO(dev)->gen > 5)
>  			intel_reset_gt_powersave(dev);
> -
> -		intel_hpd_init(dev);
>  	} else {
>  		mutex_unlock(&dev->struct_mutex);
>  	}
> -- =

> 2.0.1

-- =

Ville Syrj=E4l=E4
Intel OTC