From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Don't reinit hpd interrupts after gpu reset Date: Tue, 9 Sep 2014 17:14:22 +0200 Message-ID: <20140909151422.GL15520@phenom.ffwll.local> References: <1410193038-328-1-git-send-email-daniel.vetter@ffwll.ch> <20140909130315.GG4193@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 6CA2B6E174 for ; Tue, 9 Sep 2014 08:13:58 -0700 (PDT) Received: by mail-wi0-f172.google.com with SMTP id q5so1406877wiv.17 for ; Tue, 09 Sep 2014 08:13:57 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140909130315.GG4193@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Tue, Sep 09, 2014 at 04:03:15PM +0300, Ville Syrj=E4l=E4 wrote: > On Mon, Sep 08, 2014 at 06:17:18PM +0200, Daniel Vetter wrote: > > Somehow I've overlooked this when simplifying the irq reinit > > scheme on gen4.5+ in > > = > > commit 78ad455fd229c6f6cc2f390ccbe0d8f1a62d55a9 > > Author: Daniel Vetter > > Date: Thu May 22 22:18:21 2014 +0200 > > = > > drm/i915: Improve irq handling after gpu resets > > = > > Since display interrups in general survive a gpu reset on those > > platforms there's also no need to reinit the hotplug settings. > > = > > Cc: Ville Syrj=E4l=E4 > > Signed-off-by: Daniel Vetter > = > This matches my observations on actual hardware. IIRC I looked at the > reset vs. interrupt registers at least on ILK and IVB and the registers > retained their current values on both. > = > Reviewed-by: Ville Syrj=E4l=E4 Queued for -next, thanks for the patch. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch