From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [RFC 2/3] drm/i915: create intel_update_pipe_size() Date: Tue, 9 Sep 2014 14:43:14 -0300 Message-ID: <20140909174314.GD26794@joana> References: <1410273801-20300-1-git-send-email-gustavo@padovan.org> <1410273801-20300-2-git-send-email-gustavo@padovan.org> <20140909155318.GK4193@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <20140909155318.GK4193@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org, Gustavo Padovan , dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org 2014-09-09 Ville Syrj=E4l=E4 : > On Tue, Sep 09, 2014 at 11:43:20AM -0300, Gustavo Padovan wrote: > > From: Gustavo Padovan > > = > > Factor out a piece of code from intel_pipe_set_base() that updates > > the pipe size and adjust fitter. > > = > > This will help refactor the update primary plane path. > > = > > Signed-off-by: Gustavo Padovan > > --- > > drivers/gpu/drm/i915/intel_display.c | 71 +++++++++++++++++++++-------= -------- > > 1 file changed, 41 insertions(+), 30 deletions(-) > > = > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i91= 5/intel_display.c > > index 2ccf7c0..e7e7184 100644 > > --- a/drivers/gpu/drm/i915/intel_display.c > > +++ b/drivers/gpu/drm/i915/intel_display.c > > @@ -2779,6 +2779,46 @@ static bool intel_crtc_has_pending_flip(struct d= rm_crtc *crtc) > > return pending; > > } > > = > > +static void intel_update_pipe_size(struct drm_crtc *crtc) > = > These days we usually prefer to pass intel_crtc instead of drm_crtc. You > can still call it 'crtc' since that's shorter and because we don't need > anything from drm_crtc in this function there won't be any confusion > between the two. Actually we need the drm_crtc 3 times in this function, that is why I left = it as an argument. We could just do the other way around and get it from &intel_crtc->base. Gustavo