Re: [PATCH 0/2] Couple of patches on top of the SKL latency retrieval

Rodrigo Vivi
2014-11-04T19:00:47Z

just a warn/heads-up: I had listed this one for -collector but got a
conflict because skl latency retrieval didn't get merged yet.

On Fri, Sep 5, 2014 at 5:53 AM, Damien Lespiau <damien.lespiau@intel.com> wrote:
> Ville had 2 comments on the SKL memory latency patch that are better addressed
> as separate patches on top.
>
> Patch 1: SKL unifies the plane hw and their latencies to fech data from memory
> is identical. So SKL only needs a single array. We save some room by using
> anymous union/structs. However, last time I tried that (shared DPLL state),
> Daniel didn't like it. So separate that into its own patch so it can be easily
> rejected.
>
> Patch 2: While it shouldn't cause any harm and DATA1 is likely unused by the
> pcode firmware, we don't actually know. So it's better to have as a separate
> patch, just in case a revert is needed (for testing or otherwise).
>
> --
> Damien
>
> Damien Lespiau (2):
> drm/i915: Use anonymous union/struct to save space taken by latency
> values
> drm/i915: Clear PCODE_DATA1 on SNB+
>
> drivers/gpu/drm/i915/i915_drv.h | 38 +++++++++++++++++++++-----------------
> drivers/gpu/drm/i915/i915_reg.h | 2 +-
> drivers/gpu/drm/i915/intel_pm.c | 3 +--
> 3 files changed, 23 insertions(+), 20 deletions(-)
>
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br