From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Assert correct locking for drm_send_vblank_event
Date: Fri, 12 Sep 2014 17:34:56 +0200 [thread overview]
Message-ID: <20140912153456.GH4740@phenom.ffwll.local> (raw)
In-Reply-To: <20140912152329.GI16043@nuc-i3427.alporthouse.com>
On Fri, Sep 12, 2014 at 04:23:29PM +0100, Chris Wilson wrote:
> On Fri, Sep 12, 2014 at 03:40:56PM +0200, Daniel Vetter wrote:
> > The comment says that the caller must hold the dev->event_lock
> > spinlock, so let's enforce this.
> >
> > A quick audit over all driver shows that except for the one place in
> > i915 which motivated this all callers fullfill this requirement
> > already.
>
> Replace the rogue WARN_ON_SMP(!spin_is_locked(&dev->event_lock)) in
> send_vblank_event() as well then.
Meh, I've missed that one, that's actually better I think. I'll drop my
patch here.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-09-12 15:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 13:40 [PATCH] drm: Assert correct locking for drm_send_vblank_event Daniel Vetter
2014-09-12 15:23 ` Chris Wilson
2014-09-12 15:34 ` Daniel Vetter [this message]
2014-09-12 16:04 ` [Intel-gfx] " Chris Wilson
2014-09-12 17:03 ` Peter Hurley
2014-09-12 17:25 ` [Intel-gfx] " Daniel Vetter
2014-09-12 17:42 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140912153456.GH4740@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox