From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v3 4/4] drm/i915: Support variable cursor
 height on ivb+
Date: Mon, 15 Sep 2014 16:31:53 +0300
Message-ID: <20140915133153.GF12416@intel.com>
References: <1410530426-4905-1-git-send-email-ville.syrjala@linux.intel.com>
 <1410544415-3059-1-git-send-email-ville.syrjala@linux.intel.com>
 <1410544415-3059-4-git-send-email-ville.syrjala@linux.intel.com>
 <20140913162323.GQ16043@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTP id 4F4D989EEB
 for <intel-gfx@lists.freedesktop.org>; Mon, 15 Sep 2014 06:32:33 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140913162323.GQ16043@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Sat, Sep 13, 2014 at 05:23:23PM +0100, Chris Wilson wrote:
> On Fri, Sep 12, 2014 at 08:53:35PM +0300, ville.syrjala@linux.intel.com w=
rote:
> > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > =

> > IVB introduced the CUR_FBC_CTL register which allows reducing the cursor
> > height down to 8 lines from the otherwise square cursor dimensions.
> > Implement support for it.
> > =

> > Commandeer the otherwise unused intel_crtc->cursor_size to track the
> > current value of CUR_FBC_CTL so that we can avoid duplicating the
> > complicated device type checks in i9xx_update_cursor().
> > =

> > One caveat to note is that CUR_FBC_CTL can't be used with 180 degree
> > rotation, so when cursor rotation gets introduced some extra checks are
> > needed.
> =

> Where would be a good place to put that note into a comment?

I guess I could stick it into cursor_size_ok().

> =

> So other than the mystery of rotated cursors, the code looks clear
> enough. One side question, is the CHV/VLV conflation correct here?

Yes. It's still the same old g4x derived display controller.

-- =

Ville Syrj=E4l=E4
Intel OTC