From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Revert "drm/i915: Reject the pin
 ioctl on gen6+"
Date: Fri, 19 Sep 2014 17:34:47 +0200
Message-ID: <20140919153447.GD15734@phenom.ffwll.local>
References: <1404371555-3760-1-git-send-email-damien.lespiau@intel.com>
 <20140707210455.GF17271@phenom.ffwll.local>
 <20140919142555.GA19670@strange.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49])
 by gabe.freedesktop.org (Postfix) with ESMTP id E812B6E1FB
 for <intel-gfx@lists.freedesktop.org>; Fri, 19 Sep 2014 08:34:20 -0700 (PDT)
Received: by mail-wg0-f49.google.com with SMTP id m15so2624400wgh.20
 for <intel-gfx@lists.freedesktop.org>; Fri, 19 Sep 2014 08:34:20 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140919142555.GA19670@strange.ger.corp.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, Tomasz Madajczak <tomasz.madajczak@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Sep 19, 2014 at 03:25:55PM +0100, Damien Lespiau wrote:
> Hi Daniel,
> 
> On Mon, Jul 07, 2014 at 11:04:55PM +0200, Daniel Vetter wrote:
> > On Thu, Jul 03, 2014 at 08:12:35AM +0100, Damien Lespiau wrote:
> > > This reverts commit 02f6bcccf7c324115747aae2f0addd6af5d321cd.
> > > 
> > > The OA buffer can contain global data (in particular, not linked to a
> > > context or a single batch execution) about GPU events (eg. hw context
> > > switches, rc6 transitions, frequency changes, ...) and needs to be
> > > mapped to GGTT. The pin ioctl provided a way to do that.
> > > 
> > > Admittedly, this change broke what seems to be a valid use case of
> > > pinning a buffer in GGTT, even when PPGTT is used (which is the reason
> > > invoked in the commit message).
> > 
> > Global OA buffers should be handled by the kernel and exposed through
> > perf, imo. I think I'll go lalala on this a bit longer ...
> 
> Do you think that we can unblock this now that we have somewhat of path
> forward with Rob Bragg's work? I'm still uneasy with a precedent where
> we break working applications and it takes a long time for us to revert
> the offending change?

I still consider pinning stuff behind the kernels back too evil. So if
people want that I'd like to see the use-case and why we can't do this
differently.

And I've never approved of the pin ioctl but really loudly complained
about each occasion I've spotted, so I think the internal users just have
to keep the pieces for a bit longer.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch