From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/8] drm/i915: Introduce a PV INFO page structure for Intel GVT-g. Date: Fri, 19 Sep 2014 18:07:29 +0200 Message-ID: <20140919160729.GO15734@phenom.ffwll.local> References: <1411152428-7226-1-git-send-email-jike.song@intel.com> <1411152428-7226-2-git-send-email-jike.song@intel.com> <20140919160246.GM15734@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 70CE789B9E for ; Fri, 19 Sep 2014 09:07:02 -0700 (PDT) Received: by mail-wi0-f177.google.com with SMTP id em10so3308553wid.10 for ; Fri, 19 Sep 2014 09:07:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140919160246.GM15734@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jike Song Cc: daniel.vetter@intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Sep 19, 2014 at 06:02:46PM +0200, Daniel Vetter wrote: > I think a new header file i915_vgt.h for these definitions would be good. > i915_reg.h is giant already ... Separate header would also lend itself well for some kerneldoc DOC: overview section and for properly documenting all the vgt_ interface functions. See e.g. the cmd parser for a nice example of how to integrate a documentation for new features into our drm driver docbook. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch