From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH 33/89] drm/i915/skl: Sunrise Point PCH detection Date: Mon, 22 Sep 2014 14:42:32 +0100 Message-ID: <20140922134232.GI10951@strange.ger.corp.intel.com> References: <1409830075-11139-1-git-send-email-damien.lespiau@intel.com> <1409830075-11139-34-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 73DF26E404 for ; Mon, 22 Sep 2014 06:42:34 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Wed, Sep 17, 2014 at 03:18:21PM -0700, Rodrigo Vivi wrote: > Where can I find these pch device id definitions? You'll have to trust Satheesh on that, it's not something we have documented in the GPU specs. -- Damien > On Thu, Sep 4, 2014 at 4:26 AM, Damien Lespiau > wrote: > > From: Satheeshakrishna M > > This patch implements detection of SPT and SPT-LP PCH devices. > > v2: Added HAS_PCH_SPT macro > > Signed-off-by: Satheeshakrishna M > Signed-off-by: Damien Lespiau > --- > drivers/gpu/drm/i915/i915_drv.c | 10 ++++++++++ > drivers/gpu/drm/i915/i915_drv.h | 4 ++++ > 2 files changed, 14 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_drv.c > b/drivers/gpu/drm/i915/i915_drv.c > index 3d7f823..c6a8a80 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -475,6 +475,16 @@ void intel_detect_pch(struct drm_device *dev) > DRM_DEBUG_KMS("Found LynxPoint LP > PCH\n"); > WARN_ON(!IS_HASWELL(dev)); > WARN_ON(!IS_ULT(dev)); > + } else if (id == INTEL_PCH_SPT_DEVICE_ID_TYPE) { > + dev_priv->pch_type = PCH_SPT; > + DRM_DEBUG_KMS("Found SunrisePoint > PCH\n"); > + WARN_ON(!IS_SKYLAKE(dev)); > + WARN_ON(IS_ULT(dev)); > + } else if (id == > INTEL_PCH_SPT_LP_DEVICE_ID_TYPE) { > + dev_priv->pch_type = PCH_SPT; > + DRM_DEBUG_KMS("Found SunrisePoint LP > PCH\n"); > + WARN_ON(!IS_SKYLAKE(dev)); > + WARN_ON(!IS_ULT(dev)); > } else > continue; > > diff --git a/drivers/gpu/drm/i915/i915_drv.h > b/drivers/gpu/drm/i915/i915_drv.h > index cf4fc86..be82888 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -699,6 +699,7 @@ enum intel_pch { > PCH_IBX, /* Ibexpeak PCH */ > PCH_CPT, /* Cougarpoint PCH */ > PCH_LPT, /* Lynxpoint PCH */ > + PCH_SPT, /* Sunrisepoint PCH */ > PCH_NOP, > }; > > @@ -2184,8 +2185,11 @@ struct drm_i915_cmd_table { > #define INTEL_PCH_PPT_DEVICE_ID_TYPE 0x1e00 > #define INTEL_PCH_LPT_DEVICE_ID_TYPE 0x8c00 > #define INTEL_PCH_LPT_LP_DEVICE_ID_TYPE 0x9c00 > +#define INTEL_PCH_SPT_DEVICE_ID_TYPE 0xA100 > +#define INTEL_PCH_SPT_LP_DEVICE_ID_TYPE 0x9D00 > > #define INTEL_PCH_TYPE(dev) (to_i915(dev)->pch_type) > +#define HAS_PCH_SPT(dev) (INTEL_PCH_TYPE(dev) == PCH_SPT) > #define HAS_PCH_LPT(dev) (INTEL_PCH_TYPE(dev) == PCH_LPT) > #define HAS_PCH_CPT(dev) (INTEL_PCH_TYPE(dev) == PCH_CPT) > #define HAS_PCH_IBX(dev) (INTEL_PCH_TYPE(dev) == PCH_IBX) > -- > 1.8.3.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > -- > Rodrigo Vivi > Blog: http://blog.vivi.eng.br >