From mboxrd@z Thu Jan  1 00:00:00 1970
From: Damien Lespiau <damien.lespiau@intel.com>
Subject: Re: [PATCH 4/5] drm/i915: Let number of workarounds
	more	clear
Date: Fri, 26 Sep 2014 14:02:14 +0100
Message-ID: <20140926130214.GA24135@strange.ger.corp.intel.com>
References: <1411172190-1642-1-git-send-email-rodrigo.vivi@intel.com>
 <1411172190-1642-4-git-send-email-rodrigo.vivi@intel.com>
 <87ppeilgg2.fsf@gaia.fi.intel.com> <87r3yylevx.fsf@intel.com>
 <20140926125812.GB9308@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTP id AD3426E08C
 for <intel-gfx@lists.freedesktop.org>; Fri, 26 Sep 2014 06:02:17 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140926125812.GB9308@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, Jani Nikula <jani.nikula@linux.intel.com>, Mika Kuoppala <mika.kuoppala@linux.intel.com>, Rodrigo Vivi <rodrigo.vivi@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Sep 26, 2014 at 01:58:12PM +0100, Chris Wilson wrote:
> > > I have a bit mixed feelings with this patch as I have tripped
> > > around here myself recently.
> > >
> > > I think we should just drop this patch and use:
> > > ret = intel_ring_begin(ring, 3 * <amount>) on the subsequent
> > > patches that modify the amount.
> > >
> > > This way the intel_ring_begin will always be the one that
> > > shows in a diff. And raises alarm if it doesnt. We don't want
> > > this to be too transparent and looking too easy for the next reader.
> > > As the reviewer is the only and last line of defense ensuring
> > > symmetry between intel_ring_begin and amount of emits.
> > 
> > Considering intel_ring_emit_wa() adds all the needed information to
> > dev_priv->intel_wa_regs and dev_priv->num_wa_regs anyway, we could
> > trivially split this into constructing dev_priv->intel_wa_regs first,
> 
> And only *once*.

Note that Arun is signed up to fix all of that, starting with proposing
changes upfront.

-- 
Damien