From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v3] drm/i915: Add ppgtt create/release trace points Date: Mon, 29 Sep 2014 15:06:00 +0200 Message-ID: <20140929130600.GL4109@phenom.ffwll.local> References: <1411661457-4819-1-git-send-email-daniele.ceraolospurio@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f170.google.com (mail-we0-f170.google.com [74.125.82.170]) by gabe.freedesktop.org (Postfix) with ESMTP id DCF0D6E251 for ; Mon, 29 Sep 2014 06:06:03 -0700 (PDT) Received: by mail-we0-f170.google.com with SMTP id q58so3467033wes.15 for ; Mon, 29 Sep 2014 06:06:02 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1411661457-4819-1-git-send-email-daniele.ceraolospurio@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: daniele.ceraolospurio@intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Sep 25, 2014 at 05:10:57PM +0100, daniele.ceraolospurio@intel.com wrote: > From: Daniele Ceraolo Spurio > > These tracepoints are useful for observing the creation and > destruction of Full PPGTTs. > > Signed-off-by: Daniele Ceraolo Spurio Ok, I think this is an excellent opportunity to properly document the tracepoints we already have. Since kerneldocs sucks I guess we need to do it all with DOC: comments that get manually pulled in, with an overview comment at the top of i915_trace.h. That then also leaves you with a nice place to explain a bit what this should be used for. -Daniel > --- > drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++++ > drivers/gpu/drm/i915/i915_trace.h | 40 +++++++++++++++++++++++++++++++++++++ > 2 files changed, 44 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c > index be0aa29..5577e86 100644 > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c > @@ -1174,6 +1174,8 @@ i915_ppgtt_create(struct drm_device *dev, struct drm_i915_file_private *fpriv) > > ppgtt->file_priv = fpriv; > > + trace_i915_ppgtt_create(ppgtt); > + > return ppgtt; > } > > @@ -1182,6 +1184,8 @@ void i915_ppgtt_release(struct kref *kref) > struct i915_hw_ppgtt *ppgtt = > container_of(kref, struct i915_hw_ppgtt, ref); > > + trace_i915_ppgtt_release(ppgtt); > + > /* vmas should already be unbound */ > WARN_ON(!list_empty(&ppgtt->base.active_list)); > WARN_ON(!list_empty(&ppgtt->base.inactive_list)); > diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h > index f5aa006..ca84c49 100644 > --- a/drivers/gpu/drm/i915/i915_trace.h > +++ b/drivers/gpu/drm/i915/i915_trace.h > @@ -587,6 +587,46 @@ TRACE_EVENT(intel_gpu_freq_change, > TP_printk("new_freq=%u", __entry->freq) > ); > > +TRACE_EVENT(i915_ppgtt_create, > + TP_PROTO(struct i915_hw_ppgtt *ppgtt), > + > + TP_ARGS(ppgtt), > + > + TP_STRUCT__entry( > + __field(struct i915_address_space *, vm) > + __field(u32, dev) > + __field(u32, pid) > + ), > + > + TP_fast_assign( > + __entry->vm = &ppgtt->base; > + __entry->dev = ppgtt->base.dev->primary->index; > + __entry->pid = (unsigned int)task_pid_nr(current); > + ), > + > + TP_printk("dev=%u, task_pid=%u, vm=%p", > + __entry->dev, __entry->pid, __entry->vm) > +); > + > +TRACE_EVENT(i915_ppgtt_release, > + > + TP_PROTO(struct i915_hw_ppgtt *ppgtt), > + > + TP_ARGS(ppgtt), > + > + TP_STRUCT__entry( > + __field(struct i915_address_space *, vm) > + __field(u32, dev) > + ), > + > + TP_fast_assign( > + __entry->vm = &ppgtt->base; > + __entry->dev = ppgtt->base.dev->primary->index; > + ), > + > + TP_printk("dev=%u, vm=%p", __entry->dev, __entry->vm) > +); > + > #endif /* _I915_TRACE_H_ */ > > /* This part must be outside protection */ > -- > 1.8.5.2 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch