From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Intel-gfx@lists.freedesktop.org,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>,
"Barbalho, Rafael" <rafael.barbalho@intel.com>
Subject: Re: [PATCH] drm/i915: Do not leak pages when freeing userptr objects
Date: Mon, 29 Sep 2014 15:22:50 +0200 [thread overview]
Message-ID: <20140929132250.GQ4109@phenom.ffwll.local> (raw)
In-Reply-To: <20140926145551.GC9308@nuc-i3427.alporthouse.com>
On Fri, Sep 26, 2014 at 03:55:51PM +0100, Chris Wilson wrote:
> On Fri, Sep 26, 2014 at 03:05:22PM +0100, Tvrtko Ursulin wrote:
> > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >
> > sg_alloc_table_from_pages() can build us a table with coalesced ranges which
> > means we need to iterate over pages and not sg table entries when releasing
> > page references.
> >
> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: "Barbalho, Rafael" <rafael.barbalho@intel.com>
>
> Oh that's fun. I blame Imre for the recent invention of for_each_sg_page()!
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: stable@vger.kernel.org
Again merged to dinf for vetting time, thanks for patch&review.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-09-29 13:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 14:05 [PATCH] drm/i915: Do not leak pages when freeing userptr objects Tvrtko Ursulin
2014-09-26 14:30 ` Barbalho, Rafael
2014-09-26 14:55 ` Chris Wilson
2014-09-29 13:18 ` Jani Nikula
2014-09-29 13:22 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140929132250.GQ4109@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=rafael.barbalho@intel.com \
--cc=tvrtko.ursulin@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox