From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Don't spam dmesg with rps messages on vlv/chv Date: Mon, 29 Sep 2014 16:54:05 +0200 Message-ID: <20140929145405.GU4109@phenom.ffwll.local> References: <1409659937-19459-1-git-send-email-ville.syrjala@linux.intel.com> <8761h6i4dn.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 7EE936E0C8 for ; Mon, 29 Sep 2014 07:54:08 -0700 (PDT) Received: by mail-wi0-f177.google.com with SMTP id cc10so1245695wib.16 for ; Mon, 29 Sep 2014 07:54:07 -0700 (PDT) Content-Disposition: inline In-Reply-To: <8761h6i4dn.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Sep 02, 2014 at 03:38:44PM +0300, Jani Nikula wrote: > On Tue, 02 Sep 2014, ville.syrjala@linux.intel.com wrote: > > From: Ville Syrj=E4l=E4 > > > > If the GPU frequency isn't going to change don't spam dmesg with > > debug messages about it. > > > > Signed-off-by: Ville Syrj=E4l=E4 > = > Oh yes please! > = > Reviewed-by: Jani Nikula Queued for -next-fixes, thanks for the patch. -Daniel > = > = > > --- > > drivers/gpu/drm/i915/intel_pm.c | 13 +++++++------ > > 1 file changed, 7 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/int= el_pm.c > > index 78e39f8..9bc44f0 100644 > > --- a/drivers/gpu/drm/i915/intel_pm.c > > +++ b/drivers/gpu/drm/i915/intel_pm.c > > @@ -3488,17 +3488,18 @@ void valleyview_set_rps(struct drm_device *dev,= u8 val) > > WARN_ON(val > dev_priv->rps.max_freq_softlimit); > > WARN_ON(val < dev_priv->rps.min_freq_softlimit); > > = > > - DRM_DEBUG_DRIVER("GPU freq request from %d MHz (%u) to %d MHz (%u)\n", > > - vlv_gpu_freq(dev_priv, dev_priv->rps.cur_freq), > > - dev_priv->rps.cur_freq, > > - vlv_gpu_freq(dev_priv, val), val); > > - > > if (WARN_ONCE(IS_CHERRYVIEW(dev) && (val & 1), > > "Odd GPU freq value\n")) > > val &=3D ~1; > > = > > - if (val !=3D dev_priv->rps.cur_freq) > > + if (val !=3D dev_priv->rps.cur_freq) { > > + DRM_DEBUG_DRIVER("GPU freq request from %d MHz (%u) to %d MHz (%u)\n= ", > > + vlv_gpu_freq(dev_priv, dev_priv->rps.cur_freq), > > + dev_priv->rps.cur_freq, > > + vlv_gpu_freq(dev_priv, val), val); > > + > > vlv_punit_write(dev_priv, PUNIT_REG_GPU_FREQ_REQ, val); > > + } > > = > > I915_WRITE(GEN6_PMINTRMSK, gen6_rps_pm_mask(dev_priv, val)); > > = > > -- = > > 1.8.5.5 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > = > -- = > Jani Nikula, Intel Open Source Technology Center > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch