From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Reinstate error level message for non-simulated gpu hangs Date: Wed, 1 Oct 2014 10:29:07 +0200 Message-ID: <20141001082907.GL12343@phenom.ffwll.local> References: <1412118259-4860-1-git-send-email-daniel.vetter@ffwll.ch> <20141001062839.GP19278@nuc-i3427.alporthouse.com> <20141001081300.GJ12343@phenom.ffwll.local> <20141001081950.GQ19278@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44]) by gabe.freedesktop.org (Postfix) with ESMTP id 39A186E15F for ; Wed, 1 Oct 2014 01:29:12 -0700 (PDT) Received: by mail-wg0-f44.google.com with SMTP id y10so440231wgg.15 for ; Wed, 01 Oct 2014 01:29:11 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20141001081950.GQ19278@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Daniel Vetter , Daniel Vetter , Intel Graphics Development , Mika Kuoppala , Kenneth Graunke , Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Wed, Oct 01, 2014 at 09:19:50AM +0100, Chris Wilson wrote: > On Wed, Oct 01, 2014 at 10:13:00AM +0200, Daniel Vetter wrote: > > On Wed, Oct 01, 2014 at 07:28:39AM +0100, Chris Wilson wrote: > > > On Wed, Oct 01, 2014 at 01:04:19AM +0200, Daniel Vetter wrote: > > > > This seems to have been accidentally lost in > > > > > > > > commit be62acb4cce1389a28296852737e3917d9cc5b25 > > > > Author: Mika Kuoppala > > > > Date: Fri Aug 30 16:19:28 2013 +0300 > > > > > > > > drm/i915: ban badly behaving contexts > > > > > > > > Without this real gpu hangs only log output at info level, which gets > > > > filtered away by piglit's testrunner. > > > > > > A successful GPU hang is not an error. Might be a warn or a notice, but > > > it certainly isn't a driver error. > > > > Well not of the kernel driver, but might very well be a bug in the > > userspace driver. With this piglit marks tests that hung the gpu as > > dmesg-fail, without this they might even pass. Ken raised this on irc and > > I agree that it's a must-have feature for developers that their testsuite > > can tell them when stuff broke. Provding this some other way is a lot more > > work and imo should be done in a separate patch, this here is just the > > minimal fix for this regression. > > I strongly disagree that we should be working around self-imposed > limitations of the test suite by making users believe their kernel is > broken. So what else should piglit do then? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch