From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH] drm/i915: Revert "drm/i915: Reject the pin ioctl on gen6+" Date: Thu, 2 Oct 2014 22:47:19 +0100 Message-ID: <20141002214719.GA29056@strange.ger.corp.intel.com> References: <1404371555-3760-1-git-send-email-damien.lespiau@intel.com> <20140707210455.GF17271@phenom.ffwll.local> <20140919142555.GA19670@strange.ger.corp.intel.com> <20140919153447.GD15734@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id B92ED6E08E for ; Thu, 2 Oct 2014 14:47:59 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Airlie Cc: Daniel Vetter , "intel-gfx@lists.freedesktop.org" , "Madajczak, Tomasz" List-Id: intel-gfx@lists.freedesktop.org Hi Dave, On Fri, Oct 03, 2014 at 07:12:53AM +1000, Dave Airlie wrote: > I thought we had an agreement that no features that were specific to > the non-open source userspace drivers would be merged to the kernel, > due to security and maintenance concerns, i.e. exactly this concern, > we now have to maintain an interface that we can't regression test in > public. Actually, the pin ioctl() has been here for quite some time, since the introduction of GEM, see: http://lwn.net/Articles/283798/ section 8.2 That's why one side is arguing that it's not acceptable to break user-space (open or closed , it doesn't matter at this point). Daniel is saying that's a legacy artefact and it shouldn't be used anymore, but breaking a user-space application is enough for me to at least suggest a revert. HTH, -- Damien