From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [Intel-gfx] [PATCH v3 10/11] drm/i915: use intel_fb_obj() macros to assign gem objects Date: Tue, 7 Oct 2014 18:52:19 +0300 Message-ID: <20141007155219.GC32511@intel.com> References: <1411579232-8668-1-git-send-email-gustavo@padovan.org> <1411579232-8668-10-git-send-email-gustavo@padovan.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <1411579232-8668-10-git-send-email-gustavo@padovan.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan Cc: intel-gfx@lists.freedesktop.org, Gustavo Padovan , dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Sep 24, 2014 at 02:20:31PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > = > Use the macros makes the code cleaner and it also checks for a NULL fb. > = > Signed-off-by: Gustavo Padovan Reviewed-by: Ville Syrj=E4l=E4 > --- > drivers/gpu/drm/i915/intel_sprite.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/i= ntel_sprite.c > index 8e5445b..5cb7321 100644 > --- a/drivers/gpu/drm/i915/intel_sprite.c > +++ b/drivers/gpu/drm/i915/intel_sprite.c > @@ -1029,8 +1029,7 @@ intel_check_sprite_plane(struct drm_plane *plane, > struct intel_crtc *intel_crtc =3D to_intel_crtc(state->crtc); > struct intel_plane *intel_plane =3D to_intel_plane(plane); > struct drm_framebuffer *fb =3D state->fb; > - struct intel_framebuffer *intel_fb =3D to_intel_framebuffer(fb); > - struct drm_i915_gem_object *obj =3D intel_fb->obj; > + struct drm_i915_gem_object *obj =3D intel_fb_obj(fb); > int crtc_x, crtc_y; > unsigned int crtc_w, crtc_h; > uint32_t src_x, src_y, src_w, src_h; > @@ -1232,9 +1231,8 @@ intel_commit_sprite_plane(struct drm_plane *plane, > struct intel_plane *intel_plane =3D to_intel_plane(plane); > enum pipe pipe =3D intel_crtc->pipe; > struct drm_framebuffer *fb =3D state->fb; > - struct intel_framebuffer *intel_fb =3D to_intel_framebuffer(fb); > - struct drm_i915_gem_object *obj =3D intel_fb->obj; > - struct drm_i915_gem_object *old_obj =3D intel_plane->obj; > + struct drm_i915_gem_object *obj =3D intel_fb_obj(fb); > + struct drm_i915_gem_object *old_obj =3D intel_fb_obj(plane->fb); > int crtc_x, crtc_y; > unsigned int crtc_w, crtc_h; > uint32_t src_x, src_y, src_w, src_h; > -- = > 1.9.3 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC