From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH 6/6] tools/null_state_gen: Add GEN9 golden context batch buffer creation Date: Fri, 10 Oct 2014 13:03:32 +0100 Message-ID: <20141010120332.GA5340@strange.ger.corp.intel.com> References: <1412873679-7895-1-git-send-email-mika.kuoppala@intel.com> <1412873679-7895-6-git-send-email-mika.kuoppala@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 4D8956E28B for ; Fri, 10 Oct 2014 05:04:22 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1412873679-7895-6-git-send-email-mika.kuoppala@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mika Kuoppala Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Oct 09, 2014 at 07:54:39PM +0300, Mika Kuoppala wrote: > From: Armin Reese > > Modifications to 'null_state_gen' so it can generate GEN9 > golden context batch buffer source for SKL. > > v2: - rebased on top of gen8 changes (Mika) > - fixed state base address command size (Mika) > - base address size macro as pages (Mika) > > v3: - rebased on top of current master (Mika) > - removed obsolete #includes (Mika) > - added copyright (Mika) > - render and component packing added (Mika) > > Cc: Damien Lespiau > Cc: Armin Reese > Cc: Volkin, Bradley D > Signed-off-by: Armin Reese (v1) > Signed-off-by: Mika Kuoppala Hi, This looks really good, I think we should just push it. There was a suggestion to make the null state generator output the copyright notice along with the generated file as well, but that can be done whenever. -- Damien