From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [Intel-gfx] [RFC PATCH 0/3] drm driver for baytrail's vxd392 Date: Wed, 15 Oct 2014 10:13:15 +0200 Message-ID: <20141015081314.GC12807@ulmo> References: <1413202502-19026-1-git-send-email-yao.cheng@intel.com> <20141014115259.GD5057@ulmo> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1238334791==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean V Kelley Cc: "Vetter, Daniel" , "intel-gfx@lists.freedesktop.org" , DRI mailing list , Fei Jiang List-Id: intel-gfx@lists.freedesktop.org --===============1238334791== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="O3RTKUHj+75w1tg5" Content-Disposition: inline --O3RTKUHj+75w1tg5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 14, 2014 at 08:50:35AM -0700, Sean V Kelley wrote: > On Tue, Oct 14, 2014 at 4:53 AM, Thierry Reding > wrote: > > On Mon, Oct 13, 2014 at 08:15:00PM +0800, Yao Cheng wrote: > >> drm/ipvr is a new GEM driver for baytrail's vxd392, which accelerates = VP8 video decoding. > >> The driver name "ipvr" means the PowerVR's IP wrapped by Intel. In the= future, ipvr may support other platforms such as Merrifield. > >> Code is placed at drivers/gpu/drm/ipvr and the following two new Kconf= ig are added: > >> CONFIG_DRM_IPVR: Build option for ipvr module > >> CONFIG_DRM_IPVR_EC: Experimental feature of error concealment > >> > >> User mode drm helper "libdrm_ipvr.so" and simple test are also include= d. > >> > >> Yao Cheng (3): > >> [1/3] drm/i915: add vxd392 bridge in i915 on baytrail > >> [2/3] drm/ipvr: ipvr drm driver for vxd392 > > > > If this is Intel-specific, why doesn't it live under the i915 driver? >=20 > It is an entirely unrelated HW IP block, VXD392. Nothing to do with > GEN aside from DRM based. With GEN you're referring to the Intel integrated GPU? And VXD392 I take it is the IP block licensed by Imagination? Baytrail and others then wrap some additional logic around this as it is integrated into the SoC? How much wrapping actually happens here? I worry that this is going to lead to a lot of duplication if we ever want to support another SoC that uses the VXD392 IP. Could the code be split into a VXD392 "library" and some driver that implements the Intel-specific glue? Finally, if this IP block is a VP8 video decoding engine only, I'm not sure DRM is the best subsystem for it. Traditionally video decoding has been done primarily in V4L2. I'm not sure that's the best fit given that it was originally designed for video capturing, but they've evolved some infrastructure to deal with encoding/decoding, whereas we have nothing like that at all in DRM. Thierry --O3RTKUHj+75w1tg5 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUPiyaAAoJEN0jrNd/PrOhJowP/3+GfPmysC5QRjfNELrWYH74 jVAAC/zb6NsGhpBCXywQnLdM/GA08ua5F+J0hqBBoRRToyTRdxIiAUvOG4nmmWrA Iz36P7nLq9RBHVCeKBAC7/qM5RMGts4J/y3tQoaNF7VjlkhNfKIJ/UqoSW2dHzaa NrI4TBcDsT+74ZkuyJyhPZJZUeo53hQtTUiI13yBid6Dr/JrrHntfENCbz5bPy6B A/aVq1taRbeOXp6vIg6lOhiFy+jyYeDvtFo0B7GaawQQ8fgNNj5C0esvEuqCbYXP pJh5RcFYYnIKOhDUo03NV7aI6Q2sGHWLLeSXo5XIFFTc+GBQ2MCRd6Dt+OqCwbt3 B+dMPv37GMIXFCZch7UqV62pCxvymGrNcC1W8jlcF3PfKWvpF7nQpEX7ibStaS+H u+AuKUPw476Wq2rW+ZseSWodEFRxKZNwVBm5yXCClONXGEHQcRCOSMxeZlJFUYso tLab8+cwsgJpxCKIZHLo3YUJ6OKo0KY6oc/Cg/QSBTz7gka2jtSNv0VabBvKhdih 2maKNAtQBkqO++NVjQJQ8MNwOMGWW8Dr+Q2AbTjbQM+JHoTthjvDVZftGehHF/i6 799MBvVts4uGBbKcDzSMqe/o5zDk7a8LtVrLDhhBg0PinJlmMhuPWJZvU7ytNf/A Vp461IRl4Oi1Odvs7fqj =KqR0 -----END PGP SIGNATURE----- --O3RTKUHj+75w1tg5-- --===============1238334791== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1238334791==--