From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/2] drm/i915: spt does not have pch backlight override bit Date: Mon, 20 Oct 2014 14:28:48 +0300 Message-ID: <20141020112848.GW4284@intel.com> References: <1412952813-4060-1-git-send-email-jani.nikula@intel.com> <1412952813-4060-2-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 2CBE4893E7 for ; Mon, 20 Oct 2014 04:28:53 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1412952813-4060-2-git-send-email-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, shuang.he@linux.intel.com List-Id: intel-gfx@lists.freedesktop.org On Fri, Oct 10, 2014 at 05:53:33PM +0300, Jani Nikula wrote: > SPT is always in the PCH override mode, and the bit MBZ. Only set > override on LPT. > = > v2: check for PCH version (Ville) > = > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrj=E4l=E4 > --- > drivers/gpu/drm/i915/intel_panel.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/in= tel_panel.c > index e3def5ad4a77..e18b3f49074c 100644 > --- a/drivers/gpu/drm/i915/intel_panel.c > +++ b/drivers/gpu/drm/i915/intel_panel.c > @@ -775,8 +775,9 @@ static void bdw_enable_backlight(struct intel_connect= or *connector) > if (panel->backlight.active_low_pwm) > pch_ctl1 |=3D BLM_PCH_POLARITY; > = > - /* BDW always uses the pch pwm controls. */ > - pch_ctl1 |=3D BLM_PCH_OVERRIDE_ENABLE; > + /* After LPT, override is the default. */ > + if (HAS_PCH_LPT(dev_priv)) > + pch_ctl1 |=3D BLM_PCH_OVERRIDE_ENABLE; > = > I915_WRITE(BLC_PWM_PCH_CTL1, pch_ctl1); > POSTING_READ(BLC_PWM_PCH_CTL1); > -- = > 2.1.0 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC