From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [Intel-gfx] [PATCH 5/6] drm/tile: expose the tile property to
 userspace
Date: Mon, 20 Oct 2014 17:34:11 +0200
Message-ID: <20141020153411.GP26941@phenom.ffwll.local>
References: <1413787036-19114-1-git-send-email-airlied@gmail.com>
 <1413787036-19114-6-git-send-email-airlied@gmail.com>
 <20141020153151.GN26941@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20141020153151.GN26941@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Dave Airlie <airlied@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Mon, Oct 20, 2014 at 05:31:51PM +0200, Daniel Vetter wrote:
> On Mon, Oct 20, 2014 at 04:37:15PM +1000, Dave Airlie wrote:
> > From: Dave Airlie <airlied@redhat.com>
> > 
> > This takes the tiling info from the connector and
> > exposes it to userspace, as a blob object in a
> > connector property.
> > 
> > The contents of the blob is ABI.
> > 
> > Signed-off-by: Dave Airlie <airlied@redhat.com>
> > ---
> >  drivers/gpu/drm/drm_crtc.c          | 36 ++++++++++++++++++++++++++++++++++++
> >  drivers/gpu/drm/i915/intel_dp_mst.c |  2 ++
> >  include/drm/drm_crtc.h              |  4 ++++
> >  3 files changed, 42 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> > index 93135d4..81e867a 100644
> > --- a/drivers/gpu/drm/drm_crtc.c
> > +++ b/drivers/gpu/drm/drm_crtc.c
> > @@ -1319,6 +1319,11 @@ static int drm_mode_create_standard_connector_properties(struct drm_device *dev)
> >  				       "PATH", 0);
> >  	dev->mode_config.path_property = dev_path;
> >  
> > +	dev->mode_config.tile_property = drm_property_create(dev,
> > +							     DRM_MODE_PROP_BLOB |
> > +							     DRM_MODE_PROP_IMMUTABLE,
> > +							     "TILE", 0);
> > +
> >  	return 0;
> >  }
> >  
> > @@ -4004,6 +4009,37 @@ int drm_mode_connector_set_path_property(struct drm_connector *connector,
> >  }
> >  EXPORT_SYMBOL(drm_mode_connector_set_path_property);
> >  
> > +int drm_mode_connector_set_tile_property(struct drm_connector *connector)
> 
> Same again, please add some kerneldoc for this function here.

While at it, please also add the missing kerneldoc for the functions
you've already added for dp mst support.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch