From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 02/16] drm/i915: remove dead code from
 legacy suspend handler
Date: Tue, 21 Oct 2014 14:11:59 +0200
Message-ID: <20141021121159.GC26941@phenom.ffwll.local>
References: <1410362229-814-1-git-send-email-imre.deak@intel.com>
 <1410362229-814-3-git-send-email-imre.deak@intel.com>
 <20141021115646.GC4284@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com
 [209.85.212.170])
 by gabe.freedesktop.org (Postfix) with ESMTP id 7618F88344
 for <intel-gfx@lists.freedesktop.org>; Tue, 21 Oct 2014 05:11:51 -0700 (PDT)
Received: by mail-wi0-f170.google.com with SMTP id hi2so10822907wib.5
 for <intel-gfx@lists.freedesktop.org>; Tue, 21 Oct 2014 05:11:50 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20141021115646.GC4284@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Oct 21, 2014 at 02:56:46PM +0300, Ville Syrj=E4l=E4 wrote:
> On Wed, Sep 10, 2014 at 06:16:55PM +0300, Imre Deak wrote:
> > The legacy DRM suspend logic (effective in UMS) doesn't handle any S4 t=
haw
> > events so we don't need to care about it either. Only S3 suspend and S4
> > freeze events are handled. Leave an assert behind to be sure.
> > =

> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> =

> Looks correct.
> =

> Although it the lack of .thaw() means there's no error recovery when
> things go south. But this is UMS so who cares.
> =

> Reviewed-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>

Queued for -next, thanks for the patch.
-Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch