From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 14/16] drm/i915: add poweroff_late handler Date: Tue, 21 Oct 2014 16:32:36 +0300 Message-ID: <20141021133236.GH4284@intel.com> References: <1410362229-814-1-git-send-email-imre.deak@intel.com> <1410362229-814-15-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id B733389CDF for ; Tue, 21 Oct 2014 11:38:11 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1410362229-814-15-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Sep 10, 2014 at 06:17:07PM +0300, Imre Deak wrote: > The suspend_late handler saves some registers and powers off the device, > so it doesn't have a big overhead. Calling it at S4 poweroff_late time > makes the power off handling identical to the S3 suspend and S4 freeze > handling, so do this for consistency. Heh. I was wondering where .poweroff_late() was when reading the earlier patches. I like consistency. Reviewed-by: Ville Syrj=E4l=E4 > = > Signed-off-by: Imre Deak > --- > drivers/gpu/drm/i915/i915_drv.c | 1 + > 1 file changed, 1 insertion(+) > = > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_= drv.c > index f6157a1..907a027 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -1520,6 +1520,7 @@ static const struct dev_pm_ops i915_pm_ops =3D { > .thaw_early =3D i915_pm_resume_early, > .thaw =3D i915_pm_resume, > .poweroff =3D i915_pm_suspend, > + .poweroff_late =3D i915_pm_suspend_late, > .restore_early =3D i915_pm_resume_early, > .restore =3D i915_pm_resume, > .runtime_suspend =3D intel_runtime_suspend, > -- = > 1.8.4 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC