From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 16/16] drm/i915: add comments on what stage a given PM handler is called Date: Tue, 21 Oct 2014 16:42:02 +0300 Message-ID: <20141021134202.GI4284@intel.com> References: <1410362229-814-1-git-send-email-imre.deak@intel.com> <1410362229-814-17-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 908416E0C3 for ; Tue, 21 Oct 2014 13:33:48 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1410362229-814-17-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Sep 10, 2014 at 06:17:09PM +0300, Imre Deak wrote: > This will hopefully make it easier to navigate the code without the need > to consult the full PM documentation. > = > Signed-off-by: Imre Deak > --- > drivers/gpu/drm/i915/i915_drv.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > = > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_= drv.c > index 55b04e6..44c9317 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -1506,10 +1506,21 @@ static int intel_resume_prepare(struct drm_i915_p= rivate *dev_priv, > } > = > static const struct dev_pm_ops i915_pm_ops =3D { > + /* S0ix, S3 event handlers */ Well, S0ix can occur in due to runtime PM as well. > .suspend =3D i915_pm_suspend, > .suspend_late =3D i915_pm_suspend_late, > .resume_early =3D i915_pm_resume_early, > .resume =3D i915_pm_resume, > + > + /* > + * S4 event handlers > + * @freeze, @freeze_late : called before creating hibernation image That's FREEZE. Also called before restoring the hibenation image (QUIESCE). > + * @thaw, @thaw_early : called after creating hibernation image, > + * before writing it That's THAW. Also called after failing the snapshot or restore (RECOVER). > + * @poweroff, @poweroff_late: called after writing hibernation image, > + * before rebooting > + * @restore, @restore_early : called after rebooting "after restoring the hibernation image" is what I'd say. That's RESTORE. > + */ > .freeze =3D i915_pm_suspend, > .freeze_late =3D i915_pm_suspend_late, > .thaw_early =3D i915_pm_resume_early, > @@ -1518,6 +1529,8 @@ static const struct dev_pm_ops i915_pm_ops =3D { > .poweroff_late =3D i915_pm_suspend_late, > .restore_early =3D i915_pm_resume_early, > .restore =3D i915_pm_resume, > + > + /* D0<->D3 (runtime PM) event handlers */ > .runtime_suspend =3D intel_runtime_suspend, > .runtime_resume =3D intel_runtime_resume, > }; > -- = > 1.8.4 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC