From: Daniel Vetter <daniel@ffwll.ch>
To: Todd Previte <tprevite@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH V2] drm/i915: Change order of operations for VLV/CHV to not train DP link before PHYs are ready
Date: Tue, 21 Oct 2014 16:41:36 +0200 [thread overview]
Message-ID: <20141021144136.GI26941@phenom.ffwll.local> (raw)
In-Reply-To: <1413571273-22919-1-git-send-email-tprevite@gmail.com>
On Fri, Oct 17, 2014 at 11:41:12AM -0700, Todd Previte wrote:
> V2 changes:
> - Moved the intel_dp_enable_port() call out of intel_dp_enable() and placed it
> before the calls to intel_dp_enable() and vlv_wait_port_ready()
> - Cleaned up a spacing issues with the code indents
> - Amended the commit message to be under 80 characters per line and expanded
> on the description of what the patch does
The per-patch commit log should be part of the commit message, above the
sob section. Some kernel maintainers want it below claiming it's noise,
but I disagree. In any case it needs to be part of the patch when
submitting it.
The cover letter changelog is just for the big stuff spawning more than
one patch when you have a big series.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-10-21 15:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 16:37 [PATCH] drm/i915: Change order of operations for VLV/CHV to not train DP link before PHYs are ready Todd Previte
2014-10-10 8:04 ` Jani Nikula
2014-10-11 0:18 ` Todd Previte
2014-10-17 18:41 ` [PATCH V2] " Todd Previte
2014-10-17 18:41 ` [PATCH 2/3] " Todd Previte
2014-10-22 7:17 ` Ville Syrjälä
2014-10-21 14:41 ` Daniel Vetter [this message]
2014-10-22 15:21 ` [PATCH V2] " Todd Previte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141021144136.GI26941@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tprevite@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox