From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH V2] drm/i915: Change order of operations for VLV/CHV to not train DP link before PHYs are ready Date: Tue, 21 Oct 2014 16:41:36 +0200 Message-ID: <20141021144136.GI26941@phenom.ffwll.local> References: <87lhoos63a.fsf@intel.com> <1413571273-22919-1-git-send-email-tprevite@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46]) by gabe.freedesktop.org (Postfix) with ESMTP id 56A4E6E1F9 for ; Tue, 21 Oct 2014 08:09:49 -0700 (PDT) Received: by mail-wg0-f46.google.com with SMTP id l18so1644762wgh.29 for ; Tue, 21 Oct 2014 08:09:48 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1413571273-22919-1-git-send-email-tprevite@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Todd Previte Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Oct 17, 2014 at 11:41:12AM -0700, Todd Previte wrote: > V2 changes: > - Moved the intel_dp_enable_port() call out of intel_dp_enable() and placed it > before the calls to intel_dp_enable() and vlv_wait_port_ready() > - Cleaned up a spacing issues with the code indents > - Amended the commit message to be under 80 characters per line and expanded > on the description of what the patch does The per-patch commit log should be part of the commit message, above the sob section. Some kernel maintainers want it below claiming it's noise, but I disagree. In any case it needs to be part of the patch when submitting it. The cover letter changelog is just for the big stuff spawning more than one patch when you have a big series. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch