From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 00/16] fix VLV S4 suspend/resume, unify S3/S4 handlers Date: Tue, 21 Oct 2014 17:42:06 +0300 Message-ID: <20141021144206.GM4284@intel.com> References: <1410362229-814-1-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id D133289E3B for ; Tue, 21 Oct 2014 11:38:11 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1410362229-814-1-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Sep 10, 2014 at 06:16:53PM +0300, Imre Deak wrote: > The first part of the patchset (1-6) fixes an S4 bug on VLV introduced > recently. The rest unifies the various S3/S4 handlers, which are in > practice the same. The only real difference - besides some unused code - > is that during S3 suspend we disable the PCI device whereas across an S4 > freeze/thaw we keep it enabled. Given that we disable everything else > anyway, we can just as well disable the PCI device there too. Doing so > allows us to handle S3 suspend/resume and S4 freeze/thaw/restore/ > power-off the same way, simplifying/clarifying things quite a bit. > = > I smoke tested this on BDW, HSW, VLV (BYT-M), IVB, GEN45. > = > Imre Deak (16): > drm/i915: vlv: fix gunit HW state corruption during S4 suspend > drm/i915: remove dead code from legacy suspend handler > drm/i915: factor out i915_drm_suspend_late > drm/i915: unify legacy S3 suspend and S4 freeze handlers > drm/i915: propagate error from legacy resume handler > drm/i915: vlv: fix switcheroo/legacy suspend/resume > drm/i915: fix S4 suspend while switcheroo state is off > drm/i915: remove unused restore_gtt_mappings optimization during > suspend > drm/i915: check for GT faults during S3 resume and S4 restore too > drm/i915: enable output polling during S4 thaw > drm/i915: disable/re-enable PCI device around S4 freeze/thaw > drm/i915: unify S3 and S4 suspend/resume handlers > drm/i915: sanitize suspend/resume helper function names > drm/i915: add poweroff_late handler > drm/i915: unify switcheroo and legacy suspend/resume handlers > drm/i915: add comments on what stage a given PM handler is called It all looks pretty decent to me. You can slap Reviewed-by: Ville Syrj=E4l=E4 onto everything except 09/16. I was a bit lazy and didn't look at that one since Chris has already checked it. > = > drivers/gpu/drm/i915/i915_dma.c | 4 +- > drivers/gpu/drm/i915/i915_drv.c | 185 +++++++++++++++-------------------= ------ > drivers/gpu/drm/i915/i915_drv.h | 4 +- > 3 files changed, 74 insertions(+), 119 deletions(-) > = > -- = > 1.8.4 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC