Re: [PATCH 1/4] drm/i915: preserve SSC if previously set v3

Daniel Vetter
2014-11-14T09:35:51Z

On Thu, Nov 13, 2014 at 10:42:20AM +0200, Jani Nikula wrote:
> On Thu, 09 Oct 2014, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > Some machines may have a broken VBT or no VBT at all, but we still want
> > to use SSC there. So check for it and keep it enabled if we see it
> > already on. Based on an earlier fix from Kristian.
> >
> > v2: honor modparam if set too (Daniel)
> > read out at init time and store for panel_use_ssc() use (Jesse)
> > v3: trust BIOS configuration over VBT like we do for DP (Jani)
> >
> > Reported-by: Kristian Høgsberg <hoegsberg@gmail.com>
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>

Queued for -next, thanks for the patch.

> In the long run I'd like to restrict changing dev_priv->vbt within
> intel_bios.c only, regardless of whether that info comes from VBT or
> what was set by the BIOS. We have a few exceptions here and there now,
> and there's not a good place to plug this one in, really.

Yeah, otoh the entire clock tree handling on earlier pch platforms is a
bit murky overall.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch