From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: add missing forcewake put on i915_wa_registers() Date: Tue, 21 Oct 2014 19:40:35 +0200 Message-ID: <20141021174035.GF26941@phenom.ffwll.local> References: <1413910688-1951-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51]) by gabe.freedesktop.org (Postfix) with ESMTP id 1ACE66E1E2 for ; Tue, 21 Oct 2014 10:40:28 -0700 (PDT) Received: by mail-wg0-f51.google.com with SMTP id b13so1982746wgh.10 for ; Tue, 21 Oct 2014 10:40:27 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1413910688-1951-1-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Tue, Oct 21, 2014 at 02:58:08PM -0200, Paulo Zanoni wrote: > From: Paulo Zanoni > > Otherwise, a simple "cat" to the debugfs file can make the machine use > much more power than needed, and prevent it from runtime suspending. > > Related commit: > > commit 8452e1d173a16d9812422a2272c4ab0f0ba81057 > Author: Mika Kuoppala > Date: Tue Oct 7 17:21:26 2014 +0300 > drm/i915: Build workaround list in ring initialization > > Cc: Mika Kuoppala > Cc: Arun Siluvery > Testcase: igt/pm_rpm/debugfs-read > Signed-off-by: Paulo Zanoni tbh I'm not even sure we want to do the manual forcewake get here - I915_READ will do it for us, and this is a debug interface. So no one should care about perf. Mika, is that right? If so I'd like to merge the inverse patch which drops the fw_get. -Daniel > --- > drivers/gpu/drm/i915/i915_debugfs.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > index 9600285..36a4baa 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -2671,6 +2671,7 @@ static int i915_wa_registers(struct seq_file *m, void *unused) > addr, value, mask, read, ok ? "OK" : "FAIL"); > } > > + gen6_gt_force_wake_put(dev_priv, FORCEWAKE_ALL); > intel_runtime_pm_put(dev_priv); > mutex_unlock(&dev->struct_mutex); > > -- > 2.1.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch