From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: add missing forcewake put on i915_wa_registers() Date: Wed, 22 Oct 2014 10:35:22 +0300 Message-ID: <20141022073522.GR4284@intel.com> References: <1413910688-1951-1-git-send-email-przanoni@gmail.com> <20141021174035.GF26941@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 3894D6E270 for ; Wed, 22 Oct 2014 00:36:07 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20141021174035.GF26941@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Tue, Oct 21, 2014 at 07:40:35PM +0200, Daniel Vetter wrote: > On Tue, Oct 21, 2014 at 02:58:08PM -0200, Paulo Zanoni wrote: > > From: Paulo Zanoni > > = > > Otherwise, a simple "cat" to the debugfs file can make the machine use > > much more power than needed, and prevent it from runtime suspending. > > = > > Related commit: > > = > > commit 8452e1d173a16d9812422a2272c4ab0f0ba81057 > > Author: Mika Kuoppala > > Date: Tue Oct 7 17:21:26 2014 +0300 > > drm/i915: Build workaround list in ring initialization > > = > > Cc: Mika Kuoppala > > Cc: Arun Siluvery > > Testcase: igt/pm_rpm/debugfs-read > > Signed-off-by: Paulo Zanoni > = > tbh I'm not even sure we want to do the manual forcewake get here - > I915_READ will do it for us, and this is a debug interface. So no one > should care about perf. Mika, is that right? If so I'd like to merge the > inverse patch which drops the fw_get. Don't we still need the idle msg disable+poll CSPWRFSM trick here on gen8? That also needs forcewake around it. > -Daniel > = > > --- > > drivers/gpu/drm/i915/i915_debugfs.c | 1 + > > 1 file changed, 1 insertion(+) > > = > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915= /i915_debugfs.c > > index 9600285..36a4baa 100644 > > --- a/drivers/gpu/drm/i915/i915_debugfs.c > > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > > @@ -2671,6 +2671,7 @@ static int i915_wa_registers(struct seq_file *m, = void *unused) > > addr, value, mask, read, ok ? "OK" : "FAIL"); > > } > > = > > + gen6_gt_force_wake_put(dev_priv, FORCEWAKE_ALL); > > intel_runtime_pm_put(dev_priv); > > mutex_unlock(&dev->struct_mutex); > > = > > -- = > > 2.1.1 > > = > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > = > -- = > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC