From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Add rotation support for cursor plane Date: Thu, 23 Oct 2014 10:49:16 +0200 Message-ID: <20141023084916.GC26941@phenom.ffwll.local> References: <1410766511-18879-2-git-send-email-sonika.jindal@intel.com> <1410767028-19227-1-git-send-email-sonika.jindal@intel.com> <000C66961D35964B9714611E548C10AD0C0E9815@BGSMSX104.gar.corp.intel.com> <20141023002924.GV22350@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by gabe.freedesktop.org (Postfix) with ESMTP id E48286E446 for ; Thu, 23 Oct 2014 01:49:08 -0700 (PDT) Received: by mail-wg0-f41.google.com with SMTP id b13so593658wgh.24 for ; Thu, 23 Oct 2014 01:49:08 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20141023002924.GV22350@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: "intel-gfx@lists.freedesktop.org" , "Kamble, Sagar A" List-Id: intel-gfx@lists.freedesktop.org On Wed, Oct 22, 2014 at 05:29:24PM -0700, Matt Roper wrote: > On Tue, Oct 07, 2014 at 08:43:46AM +0000, Jindal, Sonika wrote: > > Hi, > > > > Did anybody get a chance to look at this patch? > > > > Thanks, > > Sonika > > Looks like we waited a bit too long and the codebase has evolved, so I > needed to make some tweaks to your patches to get them to apply cleanly > on the latest di-nightly. However the overall changes here look good to > me, and we don't seem to be missing any details from the bspec, so > > Reviewed-by: Matt Roper > > After tweaking your patches to apply against the latest di-nightly, your > i-g-t test runs properly for me on IVB, as well as another simple test I > wrote myself, so you can also put > > Tested-by: Matt Roper > > Let me know if you want the rebased copies of the patches I used for > testing. Lazy maintainer here. That would be awesome ;-) Since you've frobbed the patches a bit pls also put your sob onto them. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch